That is intentional.. you can't get overflow with / , % , & , | , etc...
..
Daniel Marjamäki Senior Engineer
Evidente ES East AB Warfvinges väg 34 SE-112 51 Stockholm Sweden
Mobile:
Hello!
> I'm not sure this is a good fix. What was the specific issue (and on which
> buildbots)?
Ok.
The buildbots said:
FileCheck error:
'/home/linaro/buildbot/clang-cmake-thumbv7-a15/stage1/tools/clang/tools/extra/test/clang-tidy/Output/misc-misplaced-widening-cast.cpp.tmp.cpp.msg'
is em
danielmarjamaki added inline comments.
Comment at:
clang-tools-extra/trunk/clang-tidy/misc/MisplacedWideningCastCheck.cpp:21-23
@@ +20,5 @@
+void MisplacedWideningCastCheck::registerMatchers(MatchFinder *Finder) {
+ auto Calc = expr(anyOf(binaryOperator(anyOf(
+
On Tue, Feb 9, 2016 at 10:03 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Feb 9 14:59:05 2016
> New Revision: 260277
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260277&view=rev
> Log:
> Simplify and rename ASTMatchFinder's getCXXRecordDec
nemanjai added inline comments.
Comment at: lib/Basic/TargetInfo.cpp:231
@@ +230,3 @@
+if (hasFloat128Type() &&
+&getFloat128Format() == &llvm::APFloat::IEEEquad)
+ return Float128;
hubert.reinterpretcast wrote:
> Is it necessary to check that `__
AndyG removed reviewers: dblaikie, rsmith.
AndyG updated this revision to Diff 47426.
AndyG added a comment.
All strings matching the highest uncovered argument are now highlighted in the
diagnostic.
http://reviews.llvm.org/D15636
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaChecking.cpp
My apologies…
From: David Blaikie [mailto:dblai...@gmail.com]
Sent: Tuesday, February 09, 2016 4:42 PM
To: reviews+d17021+public+89c4dbb2f75e8...@reviews.llvm.org; Romanova, Katya
Cc: Gao, Yunzhong; Robinson, Paul; Eric Christopher; Dmitri Gribenko; Craig
Topper; Jonathan Roelofs; cfe-commits
Sub
Author: abataev
Date: Wed Feb 10 04:50:12 2016
New Revision: 260370
URL: http://llvm.org/viewvc/llvm-project?rev=260370&view=rev
Log:
Fix PR26543: add a check for definition in CXXRecordDecl.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
cfe/trunk/test/OpenMP/parallel_messages.cpp
Modified
Makes sense. I wonder though whether the check should attempt to be
platform-independent and warn regardless of whether int and long have the
same bit width. What do you think?
On Feb 10, 2016 9:35 AM, "Daniel Marjamäki"
wrote:
>
> Hello!
>
> > I'm not sure this is a good fix. What was the specif
Author: dzobnin
Date: Wed Feb 10 05:23:48 2016
New Revision: 260373
URL: http://llvm.org/viewvc/llvm-project?rev=260373&view=rev
Log:
Fix assertion "Chunk.Kind == DeclaratorChunk::Function" with attributed type.
This patch is to upgrade FunctionTypeUnwrapper for correct processing of
AttributedTy
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260373: Fix assertion "Chunk.Kind ==
DeclaratorChunk::Function" with attributed type. (authored by dzobnin).
Changed prior to commit:
http://reviews.llvm.org/D15373?vs=45179&id=47434#toc
Repository:
Author: abataev
Date: Wed Feb 10 05:29:16 2016
New Revision: 260374
URL: http://llvm.org/viewvc/llvm-project?rev=260374&view=rev
Log:
[OPENMP 4.5] Initial support for data members in 'firstprivate' clause.
OpenMP 4.5 allows privatization of non-static data members of current
class in non-static me
andreybokhanko added a comment.
Ping
http://reviews.llvm.org/D16851
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260376: [X86] Fix stack alignment for MCU target (Clang
part), by Anton Nadolskiy. (authored by aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D15647?vs=43788&id=47440#toc
Repository:
rL
Author: aturetsk
Date: Wed Feb 10 05:58:46 2016
New Revision: 260376
URL: http://llvm.org/viewvc/llvm-project?rev=260376&view=rev
Log:
[X86] Fix stack alignment for MCU target (Clang part), by Anton Nadolskiy.
This patch fixes stack alignments for MCU (should be aligned to 4 bytes).
Differential
Hahnfeld updated this revision to Diff 47441.
Hahnfeld added a comment.
Address reviewers' comments:
- check for valid `CLANG_DEFAULT_CXX_STDLIB`
- generalize for `Darwin` and `Bitrig` by introducing `GetDefaultCXXStdlibType`
- fallback to `CLANG_DEFAULT_CXX_STDLIB` if user choice is incorrect
Hello!
That would make some sense to me.
To catch portability issues users could use different relevant targets. Do you
know if some do that?
Best regards,
Daniel Marjamäki
..
Danie
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
In http://reviews.llvm.org/D15920#347352, @beanz wrote:
> Is it correct to assume that all the test case changes are needed just to
> make the tests pass if you set CLANG_DEFAULT_CXX_STDLIB=libc++?
>
> [...]
Yes, most of the
djasper added a subscriber: djasper.
djasper closed this revision.
djasper added a comment.
Submitted as r260378.
http://reviews.llvm.org/D16524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: djasper
Date: Wed Feb 10 06:42:58 2016
New Revision: 260378
URL: http://llvm.org/viewvc/llvm-project?rev=260378&view=rev
Log:
clang-format sort include use the source file name to determine the
"main include" that will be the 1st include (category 0).
Because the clang-format visual studi
Author: aturetsk
Date: Wed Feb 10 06:56:10 2016
New Revision: 260379
URL: http://llvm.org/viewvc/llvm-project?rev=260379&view=rev
Log:
Reapply the patch of r260376.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llvm.org/viewvc/llvm-project/
On Wed, Feb 10, 2016 at 3:23 AM, Daniel Marjamäki
wrote:
>
> That is intentional.. you can't get overflow with / , % , & , | , etc...
You can get overflow with / and %. Consider:
int i = INT_MIN / -1; // similar for %
~Aaron
>
> .
xazax.hun added inline comments.
Comment at: docs/clang-tidy/checks/misc-suspicious-semicolon.rst:35
@@ +34,3 @@
+
+if(x >= y);
+x -= y;
hokein wrote:
> The doc needs to be updated.
>
> With your latest patch, this is also a warning case.
The documentatio
xazax.hun updated this revision to Diff 47446.
xazax.hun added a comment.
- Documentation clarification.
http://reviews.llvm.org/D16535
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SuspiciousSemicolonCheck.cpp
clang-tidy/misc/SuspiciousSemicol
On Wed, Feb 10, 2016 at 10:04 AM Manuel Klimek wrote:
> On Tue, Feb 9, 2016 at 10:03 PM Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rsmith
>> Date: Tue Feb 9 14:59:05 2016
>> New Revision: 260277
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=260277&view
> You can get overflow with / and %. Consider:
>
> int i = INT_MIN / -1; // similar for %
you are right, I did not think of that.
imho overflow still seems unlikely for / and %.
..
D
Author: bcraig
Date: Wed Feb 10 07:47:25 2016
New Revision: 260381
URL: http://llvm.org/viewvc/llvm-project?rev=260381&view=rev
Log:
Limit catopen usage to unix-like OSes
Operating systems that are not unix-like are unlikely to have access to
catopen. Instead of black-listing each one, we now fil
hokein added a comment.
LGTM, thanks for working on this! Ping @alexfh
http://reviews.llvm.org/D16535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
congliu updated this revision to Diff 47448.
congliu marked 2 inline comments as done.
congliu added a comment.
- Generate a single warning for multiple template instantiations.
http://reviews.llvm.org/D16922
Files:
clang-tidy/misc/VirtualNearMissCheck.cpp
clang-tidy/misc/VirtualNearMissChe
Richard,
Can you be more specific?
I assume you mean something like my newly attached .h file that tests
very basic implementation compliance (i.e., it's required, but not
sufficient), but I would need a bit more guidance about the structure
of the file, how to perform the tests, and where to exa
sugak created this revision.
sugak added a reviewer: beanz.
sugak added subscribers: hans, cfe-commits.
Herald added a subscriber: joker.eph.
When cmake is run with `-DLLVM_ENABLE_PIC=OFF`, build fails while
linking shared library libLTO.so, because its dependencies are built
with -fno-PIC. More d
sidney added a comment.
Quick note: this is my first contribution, born from the Clang/LLVM sprint last
weekend. Marshall helped me get started.
http://reviews.llvm.org/D17043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
sidney created this revision.
sidney added reviewers: mclow.lists, alexfh.
sidney added a subscriber: cfe-commits.
Currently has a whitelist of methods like std::vector::empty() which,
in a standalone statement, likely won't do what the programmer wants.
The whitelist is brittle (Did I misspell a
congliu added a comment.
The strategy has changed. Now this check does not ignore template in
instantiation, instead, it generate a single warning for some instantiation and
ignore others, so that fix is able to apply.
We do this to walk around the function copied from ASTMatchFinder, since it's
On Wed, Feb 10, 2016 at 1:15 PM, Daniel Marjamäki <
daniel.marjam...@evidente.se> wrote:
>
> Hello!
>
> That would make some sense to me.
>
> To catch portability issues users could use different relevant targets. Do
> you know if some do that?
>
They could, but I'm not sure it's a widespread pra
hintonda created this revision.
hintonda added reviewers: doug.gregor, rnk.
hintonda added a subscriber: cfe-commits.
Fixes crash referenced in PR25181 where dyn_cast is called on a null instance
of LM.Method.
http://reviews.llvm.org/D17072
Files:
lib/Parse/ParseCXXInlineMethods.cpp
Index: l
alexfh added a comment.
> The strategy has changed. Now this check does not ignore template in
> instantiation, instead, it generate a
> single warning for some instantiation and ignore others, so that fix is able
> to apply.
I'm not sure this is the right thing to do, since there might be
alexfh accepted this revision.
alexfh added a comment.
LG. Thanks!
Could you run the check on LLVM and post here a summary of results: how many
warnings are generated, whether there are any false positives (based on a
reasonably-sized random sample, if there are too many warnings to inspect all
Anastasia added inline comments.
Comment at: test/SemaOpenCL/unroll-hint-cl20.cl:1
@@ +1,2 @@
+//RUN: %clang_cc1 -O0 -cl-std=CL2.0 -fsyntax-only -verify %s
+
Could we just combine this with test/SemaOpenCL/unroll-hint.cl.
You can have two RUN lines and pass somet
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with one possible improvement. Thank you!
Comment at: clang-tidy/readability/BracesAroundStatementsCheck.cpp:181
@@ +180,3 @@
+ // IfStmt. Avoid triggering assert
On Wed, Feb 10, 2016 at 7:19 AM, Richard via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> [Please reply *only* to the list and do not include my email directly
> in the To: or Cc: of your reply; otherwise I will not see your reply.
> Thanks.]
>
> In article ,
> Richard via cfe-commits
This needs a testcase added to the tests directory.
On Wednesday, February 10, 2016, don hinton via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> hintonda created this revision.
> hintonda added reviewers: doug.gregor, rnk.
> hintonda added a subscriber: cfe-commits.
>
> Fixes crash referenc
pxli168 updated this revision to Diff 47455.
pxli168 marked 5 inline comments as done.
http://reviews.llvm.org/D16040
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CodeGenFunction.cpp
lib/Sema/SemaChecking.cpp
lib/Sema/SemaDeclAttr.cpp
lib/S
hintonda updated this revision to Diff 47456.
hintonda added a comment.
- Reformatted change with clang-format
http://reviews.llvm.org/D17072
Files:
lib/Parse/ParseCXXInlineMethods.cpp
Index: lib/Parse/ParseCXXInlineMethods.cpp
hubert.reinterpretcast added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:1169
@@ +1168,3 @@
+ if (LHSElemType == S.Context.Float128Ty &&
+ RHSElemType == S.Context.LongDoubleTy)
+return true;
nemanjai wrote:
> hubert.reinterpretcast wrote:
> > I d
alexfh added a comment.
Thank you for working on this check!
I'd like to note that there is a library-side way to mitigate this issue using
the `[[clang::warn_unused_result]]` attribute on `vector::empty()` and similar
methods:
$ cat q.cc
#if defined(__clang__)
# if __cplusplus >= 201103
esakella created this revision.
esakella added reviewers: klimek, bkramer, rsmith, spyffe.
esakella added subscribers: karies, cfe-commits.
Herald added subscribers: rengolin, aemerson.
Implemented the
VisitSubstTemplateTypeParmType
VisitDependentNameType
VisitDependentSizedArrayType
functions
yaxunl updated this revision to Diff 47460.
yaxunl added a comment.
merge two sema tests as one as Anastasia suggested.
http://reviews.llvm.org/D16686
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Basic/Diagn
congliu updated this revision to Diff 47461.
congliu marked 3 inline comments as done.
congliu added a comment.
- Allowed warnings but disallowed fix for template instantiations.
- Updated tests.
http://reviews.llvm.org/D16922
Files:
clang-tidy/misc/VirtualNearMissCheck.cpp
clang-tidy/misc/
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0.
carlo.bertolli added subscribers: sfantao, arpith-jacob, cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
Very simple but necessary extension to target directive with fi
sidney added a comment.
In http://reviews.llvm.org/D17043#348525, @alexfh wrote:
> I'd like to note that there is a library-side way to mitigate this issue
> using the `[[clang::warn_unused_result]]` attribute on `vector::empty()` and
> similar methods:
Using an attribute sounds much better t
In article ,
Daniel Marjamäki writes:
> > You can get overflow with / and %. Consider:
> >
> > int i = INT_MIN / -1; // similar for %
>
> you are right, I did not think of that.
>
> imho overflow still seems unlikely for / and %.
I thought the whole point was to flag instances where the
Hi Richard,
You are right. Actually I just need to consider the cases that there are
full instantiations of the primary template. I have changed the strategy
and not use that function.
Thanks a lot!
Cong
On Wed, Feb 10, 2016 at 2:17 AM, Richard Smith
wrote:
> On Tue, Feb 9, 2016 at 4:15 PM, Co
Author: majnemer
Date: Wed Feb 10 11:40:47 2016
New Revision: 260388
URL: http://llvm.org/viewvc/llvm-project?rev=260388&view=rev
Log:
[MS ABI] Never reference dllimport'd vtables
Referencing a dllimported vtable is impossible in a constexpr
constructor. It would be friendlier to C++ programmers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260388: [MS ABI] Never reference dllimport'd vtables
(authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D17061?vs=47407&id=47473#toc
Repository:
rL LLVM
http://reviews.llvm.org
andreybokhanko updated this revision to Diff 47475.
andreybokhanko added a comment.
John, thanks for the re-review! -- I did as you advised, and added *a lot* of
switches. :-)
Patch updated; please re-review again.
http://reviews.llvm.org/D16846
Files:
lib/AST/ExprConstant.cpp
test/Sema/b
Hi Richard,
On 9 February 2016 at 16:59, Richard Smith via cfe-commits
wrote:
> Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from
> and wcschr, wcspbrk, wcsrchr, wmemchr, and wcsstr from to
> provide a const-correct overload set even when the underlying C library does
> not.
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Repository:
rL LLVM
http://reviews.llvm.org/D17060
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: rnk
Date: Wed Feb 10 13:09:15 2016
New Revision: 260411
URL: http://llvm.org/viewvc/llvm-project?rev=260411&view=rev
Log:
Silence some MSVC false positive warnings about integer zexts and falling off
the end of a covered switch
Modified:
cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp
Author: eugenezelenko
Date: Wed Feb 10 13:11:58 2016
New Revision: 260414
URL: http://llvm.org/viewvc/llvm-project?rev=260414&view=rev
Log:
Fix some Clang-tidy readability-redundant-control-flow warnings; other minor
fixes.
Differential revision: http://reviews.llvm.org/D17060
Modified:
cfe
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me now.
Tim.
http://reviews.llvm.org/D15040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260414: Fix some Clang-tidy
readability-redundant-control-flow warnings; other minor… (authored by
eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D17060?vs=47415&id=47492#toc
Reposit
weimingz added a comment.
LGTM
http://reviews.llvm.org/D17085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ayartsev
Date: Wed Feb 10 13:46:41 2016
New Revision: 260420
URL: http://llvm.org/viewvc/llvm-project?rev=260420&view=rev
Log:
[analyzer] Windows: launch scan-build from an arbitrary location.
The following batch files allow to launch scan-build from an arbitrary location
if path to clan
hintonda updated this revision to Diff 47499.
hintonda added a comment.
- Added test for PR26077
http://reviews.llvm.org/D16971
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/pr26077-crash-on-invalid.cpp
Index: test/SemaCXX/pr26077-crash-on-invalid.cpp
==
hintonda updated this revision to Diff 47501.
hintonda added a comment.
- Added test for PR25181
http://reviews.llvm.org/D17072
Files:
lib/Parse/ParseCXXInlineMethods.cpp
test/SemaCXX/pr25181-crash-on-invalid.cpp
Index: test/SemaCXX/pr25181-crash-on-invalid.cpp
hintonda added a comment.
I don't have commit access, so if this patch is accepted, could someone please
commit it for me?
http://reviews.llvm.org/D17072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
hintonda added a comment.
I don't have commit access, so if this patch is accepted, could someone please
commit it for me?
http://reviews.llvm.org/D16971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
On Wed, Feb 10, 2016 at 10:32 AM, Tim Northover wrote:
> Hi Richard,
>
> On 9 February 2016 at 16:59, Richard Smith via cfe-commits
> wrote:
>> Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from
>> and wcschr, wcspbrk, wcsrchr, wmemchr, and wcsstr from
>> to
>> provide a con
OK, got the build working. This should be fixed in r260425. Please let
me know if you're still seeing failures.
On Wed, Feb 10, 2016 at 11:59 AM, Richard Smith wrote:
> On Wed, Feb 10, 2016 at 10:32 AM, Tim Northover
> wrote:
>> Hi Richard,
>>
>> On 9 February 2016 at 16:59, Richard Smith via c
ayartsev created this revision.
ayartsev added a reviewer: rizsotto.mailinglist.
ayartsev added a subscriber: cfe-commits.
Attached patch makes scan-build successfully accept non-existing output
directories provided via "-o" option. The directory is created in this case.
This behavior is conform
Author: ericwf
Date: Wed Feb 10 14:46:23 2016
New Revision: 260431
URL: http://llvm.org/viewvc/llvm-project?rev=260431&view=rev
Log:
Recommit r260012 - Cleanup node-type handling in the unordered containers.
This time I kept working!
This patch is the first in a series of patches that's meant t
(Re-adding the list)
Re-committed as r260431. Let me know if there is any more breakage.
@Tim Are these tests in the clang test suite? Marshall and I were just
talking about removing all together.
Could you explain who still uses it?
On Mon, Feb 8, 2016 at 4:52 PM, Eric Fiselier wrote:
> Hey
On 10 February 2016 at 12:52, Eric Fiselier wrote:
> @Tim Are these tests in the clang test suite?
Yep, at http://llvm.org/git/test-suite.git.
> Marshall and I were just talking about removing all together.
> Could you explain who still uses it?
In the test-suite, it looks like it's just thes
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for putting up with my pickyness. It looks like there are
exception safety issues with the order of `__f_ = __as_base(&__buf_)` and
`__f->__f_..__clone(__f)` in a bunch of places
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260433: Test commit, fixed "clang" to "Clang" in docs
(authored by mgrang).
Changed prior to commit:
http://reviews.llvm.org/D17085?vs=47493&id=47510#toc
Repository:
rL LLVM
http://reviews.llvm.org/
Author: mgrang
Date: Wed Feb 10 15:06:10 2016
New Revision: 260433
URL: http://llvm.org/viewvc/llvm-project?rev=260433&view=rev
Log:
Test commit, fixed "clang" to "Clang" in docs
Reviewers: weimingz
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D17085
Modified:
cf
Sunil_Srivastava added a reviewer: rsmith.
Sunil_Srivastava updated this revision to Diff 47509.
Sunil_Srivastava added a comment.
Changed the test, but the compiler code is still same, pending reply from
Richard Smith
http://reviews.llvm.org/D15095
Files:
lib/Basic/Diagnostic.cpp
test/Pre
Sunil_Srivastava added a comment.
Richard, Your comment and my concern about the getDiagnosticsInGroup is still
visible in the greyed out area.
Given that do you still want to modify getDiagnosticsInGroup ?
I have removed the separate test and added the new tests to existing files, as
you sugg
> On Feb 10, 2016, at 12:59 PM, Tim Northover wrote:
>
> On 10 February 2016 at 12:52, Eric Fiselier wrote:
>> @Tim Are these tests in the clang test suite?
>
> Yep, at http://llvm.org/git/test-suite.git.
>
>> Marshall and I were just talking about removing all together.
>> Could you explai
alexfh added a comment.
In http://reviews.llvm.org/D17043#348569, @sidney wrote:
> In http://reviews.llvm.org/D17043#348525, @alexfh wrote:
>
> > I'd like to note that there is a library-side way to mitigate this issue
> > using the `[[clang::warn_unused_result]]` attribute on `vector::empty()`
Author: rnk
Date: Wed Feb 10 15:28:38 2016
New Revision: 260435
URL: http://llvm.org/viewvc/llvm-project?rev=260435&view=rev
Log:
[clang-cl] /Z7 now generates normal debug info, not just line info
Previously LLVM could not process any debug info we produced, so it
didn't make sense to spend time
dcoughlin updated this revision to Diff 47514.
dcoughlin added a comment.
Address more of Anna's comments.
- Add a more explicit comment about checker in header comment
- Changed the checker to always use the receiver symbol rather than the self
symbol for clarity.
- Rework SuperDeallocBRVisitor
dcoughlin added a comment.
In http://reviews.llvm.org/D5238#348199, @zaks.anna wrote:
> Looks good, below are some comments which are mostly nits.
>
> What's the plan for bringing this out of alpha? Is it pending evaluation on
> real code?
I will first extend this checker to check for uses of
rsmith added a comment.
There seem to be two principled approaches here:
1. `DiagnosticsEngine` has a `Group` named `"everything"` (all of its interface
supports that group, and from the point of view of someone using
`DiagnosticsEngine` it behaves like any other group), or
2. There is no such
sidney added a comment.
In http://reviews.llvm.org/D17043#348982, @alexfh wrote:
> The attribute can have arguments (e.g. `[[deprecated("use some other API")]]
> void f();`), so if there is a good reason, an argument (e.g. a custom
> message) can be added to the `warn_unused_result` attribute.
On 10 February 2016 at 12:06, Richard Smith wrote:
> OK, got the build working. This should be fixed in r260425. Please let
> me know if you're still seeing failures.
Thanks Richard, that did it.
Tim.
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: eugenis
Date: Wed Feb 10 15:53:28 2016
New Revision: 260441
URL: http://llvm.org/viewvc/llvm-project?rev=260441&view=rev
Log:
Fix invalid casts in .
static_cast of a pointer to object before the start of the object's
lifetime has undefined behavior.
This code triggers CFI warnings.
This
eugenis closed this revision.
eugenis added a comment.
Thanks for the review!
Committed as r260441.
Repository:
rL LLVM
http://reviews.llvm.org/D16738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: ericwf
Date: Wed Feb 10 15:58:36 2016
New Revision: 260443
URL: http://llvm.org/viewvc/llvm-project?rev=260443&view=rev
Log:
Remove changes that snuck in within r260431
Modified:
libcxx/trunk/include/unordered_map
Modified: libcxx/trunk/include/unordered_map
URL:
http://llvm.org/vie
jlebar updated this revision to Diff 47520.
jlebar added a comment.
Per IRL discussion with echristo, updated so that we just bail as soon as one
subjob fails.
http://reviews.llvm.org/D16514
Files:
lib/Driver/Compilation.cpp
Index: lib/Driver/Compilation.cpp
=
> On 2016-Feb-10, at 13:25, Bob Wilson wrote:
>
>
>> On Feb 10, 2016, at 12:59 PM, Tim Northover wrote:
>>
>> On 10 February 2016 at 12:52, Eric Fiselier wrote:
>>> @Tim Are these tests in the clang test suite?
>>
>> Yep, at http://llvm.org/git/test-suite.git.
>>
>>> Marshall and I were ju
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This works for me and I can't think of anything it's going to break so LGTM.
Thanks!
-eric
http://reviews.llvm.org/D16514
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260448: Bail on compilation as soon as a job fails.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16514?vs=47520&id=47525#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Author: jlebar
Date: Wed Feb 10 16:17:00 2016
New Revision: 260448
URL: http://llvm.org/viewvc/llvm-project?rev=260448&view=rev
Log:
Bail on compilation as soon as a job fails.
Previously we attempted to be smart; if one job failed, we'd run all
jobs that didn't depend on the failing job.
Proble
jlebar created this revision.
jlebar added a reviewer: echristo.
jlebar added a subscriber: cfe-commits.
Actions don't depend on the toolchain; they get bound to a particular
toolchain via BindArch.
No functional changes.
http://reviews.llvm.org/D17100
Files:
include/clang/Driver/Driver.h
l
Author: hans
Date: Wed Feb 10 16:18:37 2016
New Revision: 260449
URL: http://llvm.org/viewvc/llvm-project?rev=260449&view=rev
Log:
Revert r260388 "[MS ABI] Never reference dllimport'd vtables"
This caused the compiler to fail with "invalid linkage type
for global declaration" (PR26569).
Modified
On Wed, Feb 10, 2016 at 9:40 AM, David Majnemer via cfe-commits
wrote:
> Author: majnemer
> Date: Wed Feb 10 11:40:47 2016
> New Revision: 260388
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260388&view=rev
> Log:
> [MS ABI] Never reference dllimport'd vtables
>
> Referencing a dllimported vta
> Can we hold off a little longer?
Yes we can. The entire point of the AFAIK was to encourage migration to
libc++ so it makes some
sense to keep them while they still serve this purpose.
When you say "a little longer" what sort of timeline do you have in mind?
It would be nice to get rid of thes
jlebar created this revision.
jlebar added reviewers: majnemer, rnk.
jlebar added subscribers: tra, jhen, cfe-commits.
We can't do the right thing, since there's no right thing to do, but at
least we can not crash the compiler.
http://reviews.llvm.org/D17103
Files:
lib/CodeGen/CGCUDABuiltin.cp
1 - 100 of 155 matches
Mail list logo
