r255099 - clang-format: Improve documentation of AlignOperands.

Author: djasper Date: Wed Dec 9 01:56:52 2015 New Revision: 255099 URL: http://llvm.org/viewvc/llvm-project?rev=255099&view=rev Log: clang-format: Improve documentation of AlignOperands. Modified: cfe/trunk/include/clang/Format/Format.h Modified: cfe/trunk/include/clang/Format/Format.h URL:

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

Hi Hans, I asked Chandler to look at this once again but seems to me he is very busy. Maybe you could ping him also? Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 09.12.2015 0:35, Hans Wennborg пишет: > hans added a comment. > > Alexey & Chandler: Is there any o

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

ABataev updated this revision to Diff 42282. ABataev added a comment. Update after review http://reviews.llvm.org/D15174 Files: lib/Sema/SemaPseudoObject.cpp test/CodeGenCXX/ms-property.cpp test/SemaCXX/ms-property-error.cpp test/SemaCXX/ms-property.cpp Index: lib/Sema/SemaPseudoObject

[PATCH] Re D12834 add gcc abi_tag support

I can't figure out how to add code to someone else's Phabricator review , so sending it here to the mailing list instead. * Attached 0001-add-gcc-abi_tag-support.patch rebases against recent trunk (there were three mino

Re: [PATCH] D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation.

jpienaar added a comment. Looks good to me. Comment at: lib/AST/RecordLayoutBuilder.cpp:2003 @@ +2002,3 @@ +return nullptr; + if (!Context.getLangOpts().CUDAIsDevice && !MD->hasAttr() && + MD->hasAttr()) Add a comment to explain asymmetry.

Re: [PATCH] D12834: add gcc abi_tag support

sberg added a subscriber: sberg. sberg added a comment. I can't figure out how to add code to someone else's Phabricator review, so sent it to the mailing list instead:

[PATCH] D15370: [scan-view] replace deprecated optparse with argparse

omtcyf0 created this revision. omtcyf0 added a reviewer: ddunbar. omtcyf0 added a subscriber: cfe-commits. scan-view migrated from optparse deprecated Python module to its replacement (argparse) and resolved few conflicts with pep8 http://reviews.llvm.org/D15370 Files: tools/scan-view/bin/sca

[PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

a.makarov created this revision. a.makarov added reviewers: aaron.ballman, rsmith. a.makarov added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. This patch is to avoid attaching the calling convention attribute to the result type if this attribute was ignored and callin

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

alexfh added a comment. In http://reviews.llvm.org/D12761#304823, @Alexander_Droste wrote: > Ah ok, I wasn't aware that clang-tidy is not restricted to checks which > verify stylistic issues. > What makes it more convenient to integrate the checks in clang-tidy? Is it > how the AST-Matcher >

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki updated this revision to Diff 42292. danielmarjamaki added a comment. I have tried to fix the comments. This patch is mostly untested. I have only run 'make check-all'. I am running more tests right now. http://reviews.llvm.org/D15332 Files: clang-tidy/readability/CMakeLists

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki marked 12 inline comments as done. Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:44 @@ +43,3 @@ + if (B->isAssignmentOp()) +markCanNotBeConst(B, false); +} else if (const auto *CE = dyn_cast(S)) { I tried to unify l

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Sorry I was a bit slow -- was out when commented in Nov, and was slow catching back up the past two weeks. I've done some more testing, and the check-libomp is passing very nicely now!

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

alexfh added a comment. Please add tests with templates and macros. Please also run this on LLVM/Clang to ensure a) it doesn't crash; b) the number of warnings is sane; c) a representative sample of warnings doesn't contain false positives. http://reviews.llvm.org/D15332 ___

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki marked 3 inline comments as done. danielmarjamaki added a comment. In http://reviews.llvm.org/D15332#305976, @alexfh wrote: > Please add tests with templates and macros. Please also run this on > LLVM/Clang to ensure a) it doesn't crash; b) the number of warnings is sane; > c) a

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist marked an inline comment as done. rizsotto.mailinglist added a comment. > Also, what do you think about renaming intercept-build to "log-build" or some > of the other alternatives I proposed above? I think it is important for the > name of the executable to communicate its p

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

ismail added a comment. Martell, any update on this? http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

fraggamuffin marked 14 inline comments as done. fraggamuffin added a comment. In http://reviews.llvm.org/D15321#304557, @ABataev wrote: > Michael, please provide full diff log, as described in > http://llvm.org/docs/Phabricator.html (with full context) Ok, no problem. Sorry I forgot. Thanks fo

r255127 - [Hexagon] Use integrated assembler by default

Author: kparzysz Date: Wed Dec 9 10:34:24 2015 New Revision: 255127 URL: http://llvm.org/viewvc/llvm-project?rev=255127&view=rev Log: [Hexagon] Use integrated assembler by default Modified: cfe/trunk/lib/Driver/ToolChains.h cfe/trunk/test/Driver/hexagon-toolchain-elf.c cfe/trunk/test

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

fraggamuffin removed rL LLVM as the repository for this revision. fraggamuffin updated this revision to Diff 42307. fraggamuffin marked an inline comment as done. fraggamuffin added a comment. This is just an interim full diff file of changes accepted so far. I still need to address the attribute

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

rjmccall added a comment. Thanks! Just a slight tweak to the comment, then LGTM. Comment at: lib/Sema/SemaPseudoObject.cpp:259 @@ +258,3 @@ +/// +/// If this method returns false, and the set value isn't capturable for +/// some reason, the result of the expression

r255129 - unique_ptrify some collections in FileManager

Author: dblaikie Date: Wed Dec 9 11:23:13 2015 New Revision: 255129 URL: http://llvm.org/viewvc/llvm-project?rev=255129&view=rev Log: unique_ptrify some collections in FileManager Modified: cfe/trunk/include/clang/Basic/FileManager.h cfe/trunk/lib/Basic/FileManager.cpp Modified: cfe/tru

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. This check partially implements PR19419. Could it be extended to variables? http://reviews.llvm.org/D15332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

RE: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

| And at runtime, on some targets, we use this: | | https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/builtins/floatuntisf.c | | ... which gives a NaN in this case. I copied that function into a test program on Ubuntu, built with gcc, and it gives me +Infinity (0x7f80) not NaN (0x7fc0

[PATCH] D15384: Don't ask for the size of dependent integral types in template diffing

rnk created this revision. rnk added a reviewer: rsmith. rnk added a subscriber: cfe-commits. In the following example, we end up diffing 'A' against 'A<>'. template struct A {}; template > R bar(); A<> &foo() { return bar(); } It appears that we end up comparing the default argument of 'S

RE: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

That doesn't seem to be the DWARF I'm seeing from Clang (& it'd be surprising if we used the typedef (or otherwise non-canonical) name in the class name): Finally getting back to this….. Ha. We don't unwrap the typedefs ("name as it is in the source"), while the upstream compiler does. Providi

Re: [PATCH] D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation.

tra added inline comments. Comment at: test/CodeGenCUDA/device-vtable.cu:36 @@ +35,3 @@ +// only device methods would be available during host or device +// compilation. For now we'll not emit such vtable at all. +class HD { jpienaar wrote: > What is the current

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

On Wed, Dec 9, 2015 at 10:40 AM, Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > That doesn't seem to be the DWARF I'm seeing from Clang (& it'd be > surprising if we used the typedef (or otherwise non-canonical) name in the > class name): > > > > Finally getting back to this….. Ha.

Re: [PATCH] D14814: [libcxx] Use __make_integer_seq builtin when available

EricWF added a comment. @majnemer Will the compiler emit diagnostics comparable to the static asserts in the other implementation? http://reviews.llvm.org/D14814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D15388: [Clang] Use autos in lib/AST/Expr.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Autos are also used for pointer variables assigned via casts or memory allocation. Patch inclu

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

Hey Richard, This caused a new error for the following code: @import Foo.X; // declaration of ‘struct foo’ from Foo.Y is not visible yet, but the pcm is loaded. struct foo *bar; // declares ‘struct foo’ @import Foo.Y; // also declares ‘struct foo’ void useFoo(struct foo *x); //

Re: [PATCH] D14814: [libcxx] Use __make_integer_seq builtin when available

majnemer added a comment. @EricWF Yes, it will. http://reviews.llvm.org/D14814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

Actually no, we prefer to have the original typedef names in the instantiation name, for source fidelity. "Name as it is in the source" or something reasonably close. Unwrapping typedefs is going too far. Re. "looseness" of the DWARF spec, it is not so loose as you like to think. Attributes

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

Richard could you do me a favor and put this on phabricator? /Eric On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith wrote: > Ping. > > On Mon, Nov 23, 2015 at 6:55 PM, Richard Smith > wrote: > >> Ping. >> >> On Thu, Nov 5, 2015 at 6:32 PM, Richard Smith >> wrote: >> >>> Ping. >>> >>> On Thu, Oct

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

On Wed, Dec 9, 2015 at 11:11 AM, Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > Actually no, we prefer to have the original typedef names in the > instantiation name, for source fidelity. > Then perhaps you should keep this change in your tree too - since that's where the need is?

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

eugenis added a comment. Hi, Have you had a chance to look at this? Repository: rL LLVM http://reviews.llvm.org/D14409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Dec 9, 2015, at 11:07 AM, Ben Langmuir wrote: > > Hey Richard, > > This caused a new error for the following code: > >@import Foo.X; // declaration of ‘struct foo’ from Foo.Y is not visible > yet, but the pcm is loaded. >struct foo *bar; // declares ‘struct foo’ >@import Foo.

RE: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

Maybe we are being too pedantic about the names. I'll have to go back and look in detail at why we decided to do that. In any case, arguably 5.5.8 (Class Template Instantiations) 1 only applies to definitions of a type, not declarations. ("Each formal parameterized type declaration appearing i

Re: [PATCH] D10834: Added functions to retrieve information about whether a vardecl is local in libclang and its python bindings.

akyrtzi added a subscriber: akyrtzi. akyrtzi added a comment. The patch does not apply cleanly, could you provide a more up-to-date one ? http://reviews.llvm.org/D10834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added a comment. In http://reviews.llvm.org/D9600#305980, @rizsotto.mailinglist wrote: > > Also, what do you think about renaming intercept-build to "log-build" or > > some of the other alternatives I proposed above? I think it is important > > for the name of the executable to commun

Re: [PATCH] D10834: Added functions to retrieve information about whether a vardecl is local in libclang and its python bindings.

The patch does not apply cleanly, could you provide a more up-to-date one ? > On Dec 6, 2015, at 11:46 PM, guibufolo+l...@gmail.com wrote: > > RedX2501 added a comment. > > Ping > > > http://reviews.llvm.org/D10834 > > > ___ cfe-commits mailing l

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

On Wed, Dec 9, 2015 at 11:59 AM, Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > Maybe we are being too pedantic about the names. I'll have to go back and > look in detail at why we decided to do that. > > > > In any case, arguably 5.5.8 (Class Template Instantiations) 1 only applie

Re: [PATCH] D14814: [libcxx] Use __make_integer_seq builtin when available

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. The only issue I have with this is that we should still test both code patchs with clang so we can ensure the fallback implementation remains correct. I would change #if __has_builtin(__mak

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

EricWF added a comment. Does the `inline` keyword have any effect when it's on function definitions that are externally instantiated? Repository: rL LLVM http://reviews.llvm.org/D14409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

On Wed, Dec 9, 2015 at 10:17 AM, Robinson, Paul via cfe-commits < cfe-commits@lists.llvm.org> wrote: > | And at runtime, on some targets, we use this: > > | > > | > https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/builtins/floatuntisf.c > > | > > | ... which gives a NaN in this case. > > >

Re: [PATCH] D14814: [libcxx] Use __make_integer_seq builtin when available

K-ballo added a comment. > After that these changes LGTM. @K-ballo I'm happy to make the changes as I > commit this if your OK with that? @EricWF Go ahead, thank you! http://reviews.llvm.org/D14814 ___ cfe-commits mailing list cfe-commits@lists.l

RE: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

| Types are a bit more vague (as to whether omitting unreferenced types is supported by the standard) DWARF 4 just says "Structure, union, and class types are represented by debugging information entries ...". There's some expansion of the "permissive" discussion in the works for DWARF 5. In e

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

akyrtzi added a comment. The patch causes tests to fail, please look into it. http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

The patch causes tests to fail, please look into it. > On Dec 8, 2015, at 10:20 PM, guibufolo+l...@gmail.com wrote: > > RedX2501 updated this revision to Diff 42267. > RedX2501 added a comment. > > Added explicit integer assignment to enum to emphasize api contract behaviour. > > > http://revi

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

Also you need to add the functions in libclang.exports. > On Dec 9, 2015, at 12:47 PM, Argyrios Kyrtzidis wrote: > > akyrtzi added a comment. > > The patch causes tests to fail, please look into it. > > > http://reviews.llvm.org/D10833 > > > ___

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

akyrtzi added a comment. Also you need to add the functions in libclang.exports. http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

On Wed, Dec 9, 2015 at 12:46 PM, Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > | Types are a bit more vague (as to whether omitting unreferenced types is > supported by the standard) DWARF 4 just says "Structure, union, and class > types are represented by debugging information ent

Re: [PATCH] D15208: Patch for inline abort code generation

danielaustin updated this revision to Diff 42328. danielaustin added a comment. Patch that removes the debug-mode sanitizer setting and makes the -fsanitize-merge-traps/-fno-sanitize-merge-traps flags, with the default setting being to merge traps. Flags tested within the Android build system,

cfe-commits@lists.llvm.org

EricWF added a comment. Added initial review comments. I need to look a little more into how we form the rvalue reference to the returned element in the case where the element is an lvalue reference. I think it's currently correct but I just want to double check. I think the new language is a

RE: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

| Oh right, sorry, off-by-one error when evaluating that by hand; I got 0x7fff (which is also a NaN, 0x7fc0 is not the only NaN). No worries. | http://llvm.org/docs/LangRef.html#uitofp-to-instruction is clear that you get an undefined result for overflow currently. Other parts of the Lan

cfe-commits@lists.llvm.org

EricWF added a comment. To expand on my concerns about lvalue elements, I would like to see tests something like this: int x = 42; int const y = 43; std::pair const p(x, y); static_assert(std::is_same(std::move(p)))>::value, ""); static_assert(std::is_same(std::move(p)))>::value, "");

Re: [PATCH] D15208: Patch for inline abort code generation

samsonov added a comment. Please consider adding a test case. Comment at: include/clang/Basic/LangOptions.h:95 @@ -94,1 +94,3 @@ + /// \brief Flag controlling whether or not trap calls are merged + /// at the end of each function. Why is it a language, not c

Re: Lit Test C++11 compatibility patch #5

Essentially LGTM. A few comments below, feel free to commit once you've addressed them. On Tue, Nov 24, 2015 at 9:53 AM, Li, Charles < charles...@playstation.sony.com> wrote: > Hi Everyone, > > > > > > I am continuing with updating Lit tests to be C++11 compatible. > > Here is the fifth patch. Th

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

On Wed, Dec 9, 2015 at 11:55 AM, Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Dec 9, 2015, at 11:07 AM, Ben Langmuir wrote: > > > > Hey Richard, > > > > This caused a new error for the following code: > > > >@import Foo.X; // declaration of ‘struct foo’ from Foo.Y

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

rnk added a subscriber: rnk. Comment at: include/clang/Sema/Sema.h:2938 @@ -2937,2 +2937,3 @@ bool CheckRegparmAttr(const AttributeList &attr, unsigned &value); + bool getCCFromAttr(const AttributeList &attr, CallingConv &CC); bool CheckCallingConvAttr(const AttributeList &

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

eugenis added a comment. In http://reviews.llvm.org/D14409#306272, @EricWF wrote: > Does the `inline` keyword have any effect when it's on function definitions > that are externally instantiated? I could not detect any difference in behavior with or without inline keyword. Remove it? Reposit

Re: [PATCH] D9600: Add scan-build python implementation

zaks.anna added a comment. Hi Laszlo, Here are some comments from me. Should we be worried about the name conflicts (between old scan-build and this tool) during rollout? I think it would be beneficial to rename the tools, but let's discuss the names later. (If we integrate Codecheck, that wil

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Dec 9, 2015, at 1:36 PM, Richard Smith wrote: > > On Wed, Dec 9, 2015 at 11:55 AM, Ben Langmuir via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > > On Dec 9, 2015, at 11:07 AM, Ben Langmuir > > wrote: > > > > Hey Richard, > > > > This caused a new

[PATCH] D15395: Add 3 more missing inline/visibility attributes

eugenis created this revision. eugenis added reviewers: EricWF, mclow.lists. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. These are the cases when an out-of-class definition of a method is marked _LIBCPP_INLINE_VISIBILITY, but the in-class decl

Re: [PATCH] D15208: Patch for inline abort code generation

danielaustin added a comment. Test makes sense, will add it with the revisions. Comment at: include/clang/Basic/LangOptions.h:95 @@ -94,1 +94,3 @@ + /// \brief Flag controlling whether or not trap calls are merged + /// at the end of each function. samsonov

[libcxx] r255162 - Use __make_integer_seq builtin for std::make_integer_sequence. Patch by K-ballo.

Author: ericwf Date: Wed Dec 9 16:03:06 2015 New Revision: 255162 URL: http://llvm.org/viewvc/llvm-project?rev=255162&view=rev Log: Use __make_integer_seq builtin for std::make_integer_sequence. Patch by K-ballo. Added: libcxx/trunk/test/std/utilities/intseq/intseq.make/make_integer_seq_fal

Re: [PATCH] D14814: [libcxx] Use __make_integer_seq builtin when available

EricWF closed this revision. EricWF added a comment. Committted in r255162. Thanks. http://reviews.llvm.org/D14814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15208: Patch for inline abort code generation

samsonov added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2543 @@ +2542,3 @@ + // RE: Bug: 25682 + if(!getLangOpts().mergeTraps) { + llvm::InlineAsm *EmptyAsm = llvm::InlineAsm::get(llvm::FunctionType::get(CGM.VoidTy, false), danielaustin wrote:

Re: [PATCH] D15030: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

mgehre updated this revision to Diff 42338. mgehre added a comment. Thanks for the comments! http://reviews.llvm.org/D15030 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIn

r255163 - fix typos; NFC

Author: spatel Date: Wed Dec 9 16:16:07 2015 New Revision: 255163 URL: http://llvm.org/viewvc/llvm-project?rev=255163&view=rev Log: fix typos; NFC Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/Che

Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. For clang this patch should have no functionality change because clang allows attributes to appear only in the declaration. GCC however was previously ignoring the attributes and only n

Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

eugenis added a comment. Should be fine. Repository: rL LLVM http://reviews.llvm.org/D15395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r255166 - Add 3 more missing inline/visibility attributes.

Author: eugenis Date: Wed Dec 9 16:32:36 2015 New Revision: 255166 URL: http://llvm.org/viewvc/llvm-project?rev=255166&view=rev Log: Add 3 more missing inline/visibility attributes. These are the cases when an out-of-class definition of a method is marked _LIBCPP_INLINE_VISIBILITY, but the in-cl

Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

eugenis closed this revision. eugenis added a comment. r255166 Repository: rL LLVM http://reviews.llvm.org/D15395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation.

tra updated the summary for this revision. tra updated this revision to Diff 42341. tra added a comment. Changed key method algorithm to ignore methods that we will not emit during this compilation (previous version didn't allow mixed host/device virtual methods). For vtables with mixed host/de

Re: [PATCH] D15367: Cross-DSO control flow integrity (Clang part)

pcc added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2558 @@ +2557,3 @@ + false)); + llvm::MDString *MDS = dyn_cast(MD); + llvm::Constant *TypeId = What happens if `MD` is not an `MDString`? Comment at: lib/CodeGen/CodeGenModu

r255172 - [CMake] Pass CMAKE_MAKE_PROGRAM through to compiler-rt build.

Author: cbieneman Date: Wed Dec 9 16:46:25 2015 New Revision: 255172 URL: http://llvm.org/viewvc/llvm-project?rev=255172&view=rev Log: [CMake] Pass CMAKE_MAKE_PROGRAM through to compiler-rt build. This is needed if your make tool is overridden. Modified: cfe/trunk/runtime/CMakeLists.txt Mo

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

On Wed, Dec 9, 2015 at 2:00 PM, Ben Langmuir wrote: > > On Dec 9, 2015, at 1:36 PM, Richard Smith wrote: > > On Wed, Dec 9, 2015 at 11:55 AM, Ben Langmuir via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> > On Dec 9, 2015, at 11:07 AM, Ben Langmuir wrote: >> > >> > Hey Richard, >> > >

Re: [PATCH] D15161: [CMake] On Darwin the LIBCXX_INSTALL_HEADERS and LIBCXX_INSTALL_LIBRARY options should default off

EricWF added a comment. > The current implementation doesn't work as intended because of CMake's > caching behavior. The CMake set command doesn't globally override cached > options. Sort of. It doesn't override the value in the cache but it should mean that the cache value is overridden by t

r255174 - Objective-C properties: loosen 'atomic' checking for readonly properties.

Author: dgregor Date: Wed Dec 9 16:57:32 2015 New Revision: 255174 URL: http://llvm.org/viewvc/llvm-project?rev=255174&view=rev Log: Objective-C properties: loosen 'atomic' checking for readonly properties. r251874 reworked the way we handle properties declared within Objective-C class extension

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. I built the library before this patch and then diffed the symbols after this change. No symbols have been removed or added. LGTM. Repository: rL LLVM http://reviews.llvm.org/D14409

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

eugenis added a comment. In http://reviews.llvm.org/D14409#306379, @eugenis wrote: > In http://reviews.llvm.org/D14409#306272, @EricWF wrote: > > > Does the `inline` keyword have any effect when it's on function definitions > > that are externally instantiated? > > > I could not detect any diffe

Re: [PATCH] D15161: [CMake] On Darwin the LIBCXX_INSTALL_HEADERS and LIBCXX_INSTALL_LIBRARY options should default off

beanz abandoned this revision. beanz added a comment. Short answer. I was doing something terrible and wrong in out-of-tree code, and this was getting tripped up. I was reading the LIBCXX_INSTALL_* variables from a higher-level CMake file. I've stopped doing that (because it was stupid), so I'l

Re: [PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv updated the summary for this revision. george.burgess.iv updated this revision to Diff 42348. george.burgess.iv added a comment. As discussed offline: - Added support for treating `const` variables as `constexpr` - Added requirement for `LValue`s with an invalid `alloc_size` bas

Re: [PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv added a comment. Also, due to allowing the evaluation of const expressions as constexpr expressions, this patch needs http://reviews.llvm.org/D14877 to go in so we don't break tests. :) http://reviews.llvm.org/D14274 ___ cfe-comm

r255176 - Fix crash on invalid initialization with std::initializer_list

Author: rnk Date: Wed Dec 9 17:18:38 2015 New Revision: 255176 URL: http://llvm.org/viewvc/llvm-project?rev=255176&view=rev Log: Fix crash on invalid initialization with std::initializer_list It is possible for CheckListElementTypes to fail without filling in any initializer list elements. Modi

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

eugenis added a comment. In http://reviews.llvm.org/D14409#306531, @eugenis wrote: > In http://reviews.llvm.org/D14409#306379, @eugenis wrote: > > > In http://reviews.llvm.org/D14409#306272, @EricWF wrote: > > > > > Does the `inline` keyword have any effect when it's on function > > > definition

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

EricWF added a comment. In http://reviews.llvm.org/D14409#306531, @eugenis wrote: > In http://reviews.llvm.org/D14409#306379, @eugenis wrote: > > > In http://reviews.llvm.org/D14409#306272, @EricWF wrote: > > > > > Does the `inline` keyword have any effect when it's on function > > > definitions

[libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

Author: eugenis Date: Wed Dec 9 17:42:30 2015 New Revision: 255177 URL: http://llvm.org/viewvc/llvm-project?rev=255177&view=rev Log: Remove visibility attributes from out-of-class method definitions in iostreams. No point in pretending that these methods are hidden - they are actually exported f

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

eugenis closed this revision. eugenis added a comment. r255177 Thanks for the review! Repository: rL LLVM http://reviews.llvm.org/D14409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

hans created this revision. hans added a reviewer: rnk. hans added a subscriber: cfe-commits. This avoids defining the same label twice if the function gets inlined. It's pretty hacky, but also very non-intrusive. (I also played with adding a flag on the MSAsmStmt and set that in ParseMicrosoftA

[libcxx] r255185 - Remove redundant _LIBCPP_ALWAYS_INLINE attribute from __convert_to_integral overloads

Author: ericwf Date: Wed Dec 9 18:43:37 2015 New Revision: 255185 URL: http://llvm.org/viewvc/llvm-project?rev=255185&view=rev Log: Remove redundant _LIBCPP_ALWAYS_INLINE attribute from __convert_to_integral overloads Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/includ

[libcxxabi] r255186 - Replace cmake check for printf with a check for fopen.

Author: eugenis Date: Wed Dec 9 18:44:42 2015 New Revision: 255186 URL: http://llvm.org/viewvc/llvm-project?rev=255186&view=rev Log: Replace cmake check for printf with a check for fopen. Printf is a builtin, and the check fails with -Werror because of a clang warning about an incompatible redec

[libcxx] r255187 - Replace cmake check for printf with a check for fopen.

Author: eugenis Date: Wed Dec 9 18:45:18 2015 New Revision: 255187 URL: http://llvm.org/viewvc/llvm-project?rev=255187&view=rev Log: Replace cmake check for printf with a check for fopen. Printf is a builtin, and the check fails with -Werror because of a clang warning about an incompatible redec

[libunwind] r255188 - Replace cmake check for printf with a check for fopen.

Author: eugenis Date: Wed Dec 9 18:47:08 2015 New Revision: 255188 URL: http://llvm.org/viewvc/llvm-project?rev=255188&view=rev Log: Replace cmake check for printf with a check for fopen. Printf is a builtin, and the check fails with -Werror because of a clang warning about an incompatible redec

Re: [clang-tools-extra] r254785 - Added coverage check for extensionless headers, and exclude hidden dot directoryies.

Hi John, > +if (file.startswith(".") || (file.find("\\.") != StringRef::npos) > + || (file.find("/.") != StringRef::npos)) This will also filter out things like ./foo.h, which probably isn't what we want and breaks on relative/non-absolute paths. For example, given a trivial test: //---

r255196 - [Lit Test] Updated 20 Lit tests to be C++11 compatible.

Author: lcharles Date: Wed Dec 9 19:07:17 2015 New Revision: 255196 URL: http://llvm.org/viewvc/llvm-project?rev=255196&view=rev Log: [Lit Test] Updated 20 Lit tests to be C++11 compatible. This is the 5th Lit test patch. Expanded expected diagnostics to vary by C++ dialect. Expanded RUN line to

[PATCH] D15400: [Clang] Use autos in lib/AST/Type.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Autos are also used for pointer variables assigned via casts or memory allocation. Patch inclu

Re: [PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks terrible, please commit. Comment at: lib/CodeGen/CGStmt.cpp:2005 @@ -1998,3 +2004,3 @@ /* IsAlignStack */ false, AsmDialect); llvm::CallInst *Resu

r255198 - PR25416: Improve performance of processing inline assembly consisting of many

Author: rsmith Date: Wed Dec 9 19:11:47 2015 New Revision: 255198 URL: http://llvm.org/viewvc/llvm-project?rev=255198&view=rev Log: PR25416: Improve performance of processing inline assembly consisting of many implicitly-concatenated string literals. When looking for the start of a token in the i

Re: [PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

majnemer added a subscriber: majnemer. Comment at: lib/CodeGen/CGStmt.cpp:2005 @@ -1998,3 +2004,3 @@ /* IsAlignStack */ false, AsmDialect); llvm::CallInst *Result = Builder.CreateCall(IA, Args); Result->addAttribute(llvm::AttributeSet::FunctionIndex

  1   2   >