Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro updated this revision to Diff 36332. loladiro added a comment. Address review comments. I had to add a special case to checkNewAttributesAfterDef if we want to use attribute merging for explicit template instantiations, because the Microsoft ABI allows adding dll attributes to the expl

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

atanasyan added inline comments. Comment at: lib/Driver/Driver.cpp:2225 @@ -2219,1 +2224,3 @@ TC = new toolchains::HexagonToolChain(*this, Target, Args); + else if ((Target.getVendor() == llvm::Triple::MipsTechnologies) && + !Target.hasEnvironment()) --

Re: [Patch][OpenCL] Custom atomic Builtin check ignores address space of a non-atomic pointer

LGTM. Related to it: There has been so many getPointerTo() issues with multi-AS in the past that I wonder if it'd be time to drop the default value from it, and go through all the places where it's called with the default AS, thus breaking multi-AS. Might be a worthwhile job to do at some point.

Re: [PATCH] D13349: [OpenCL] Casting boolean to an integer vector in OpenCL should set all bits if boolean is true

pekka.jaaskelainen added a subscriber: pekka.jaaskelainen. pekka.jaaskelainen accepted this revision. pekka.jaaskelainen added a reviewer: pekka.jaaskelainen. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGExprScalar.cpp:820 @@ -809,3 +819,3 @@ Qua

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

vkalintiris added inline comments. Comment at: lib/Driver/Driver.cpp:2225 @@ -2219,1 +2224,3 @@ TC = new toolchains::HexagonToolChain(*this, Target, Args); + else if ((Target.getVendor() == llvm::Triple::MipsTechnologies) && + !Target.hasEnvironment())

Re: [PATCH] D12854: [SourceManager] Support buffers that are not null-terminated

loladiro added a comment. Bump. Could somebody take a look at this? Repository: rL LLVM http://reviews.llvm.org/D12854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13381: Handle trailing underscores on modernize-loop-convert variable namer.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: alexfh, cfe-commits. https://llvm.org/bugs/show_bug.cgi?id=24961. http://reviews.llvm.org/D13381 Files: clang-tidy/modernize/LoopConvertUtils.cpp test/clang-tidy/modernize-loop-convert-low

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

atanasyan added inline comments. Comment at: lib/Driver/Driver.cpp:2225 @@ -2219,1 +2224,3 @@ TC = new toolchains::HexagonToolChain(*this, Target, Args); + else if ((Target.getVendor() == llvm::Triple::MipsTechnologies) && + !Target.hasEnvironment()) --

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

vkalintiris updated this revision to Diff 36344. vkalintiris added a comment. 1. s/MipsToolChain/MipsLLVMToolChain/ 2. Change to the new getCompilerRT() return type 3. clang-format http://reviews.llvm.org/D13340 Files: lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp lib/Driver/ToolChains.c

Re: [PATCH] D12854: [SourceManager] Support buffers that are not null-terminated

klimek added a subscriber: klimek. klimek added a comment. Generally, I thought clang often relies on buffers being null terminated to speed up parse times. Usually the MemoryBuffers have an option to guarantee null-terminatedness (and copy if necessary) Repository: rL LLVM http://reviews.l

[PATCH] D13383: [clang] Add flag to DeclContext to distinguish between qualified and unqualified name lookups

evgeny777 created this revision. evgeny777 added reviewers: aaron.ballman, klimek. evgeny777 added subscribers: cfe-commits, dawn, KLapshin. Hi, all! Currently lldb evaluation of qualified global variables does not work properly. I've created a revision addressing the issue, which is here: http:/

Re: [PATCH] D13349: [OpenCL] Casting boolean to an integer vector in OpenCL should set all bits if boolean is true

neil.hickey updated this revision to Diff 36348. neil.hickey added a comment. Fixing formatting problems. http://reviews.llvm.org/D13349 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGenOpenCL/bool_cast.cl Index: test/CodeGenOpenCL/bool_cast.cl ==

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

On Fri, Oct 2, 2015 at 1:26 AM, Keno Fischer wrote: > loladiro added inline comments. > > > Comment at: include/clang/Basic/Attr.td:1462 > @@ +1461,3 @@ > +def UniqueInstantiation : InheritableAttr { > + let Spellings = [GCC<"unique_instantiation">]; > + let Subjects = SubjectLi

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with one minor nit. Thank you for working on this! ~Aaron Comment at: clang-tidy/add_new_check.py:150 @@ -149,2 +149,3 @@ def adapt_module(module_path, mo

Re: [PATCH] D13157: Teach -Wtautological-overlap-compare about enums

On Thu, Oct 1, 2015 at 5:18 PM, Richard Trieu wrote: > I'm in favor of keeping the asserts around. Several times, I've seen Clang > crashers than languish in the bug tracker with an assert in a generic > casting function. And no one fixes it until someone pokes at the backtrace > to find the sou

Re: [PATCH] D13381: Handle trailing underscores on modernize-loop-convert variable namer.

klimek added inline comments. Comment at: clang-tidy/modernize/LoopConvertUtils.cpp:822 @@ -821,1 +821,3 @@ IteratorName = ContainerName.substr(0, Len - 1); +// Ej: (auto thing : things) +if (!declarationExists(IteratorName)) Do you mean: E.g.? http

Re: [PATCH] D13381: Handle trailing underscores on modernize-loop-convert variable namer.

angelgarcia updated this revision to Diff 36358. angelgarcia added a comment. I forgot one. http://reviews.llvm.org/D13381 Files: clang-tidy/modernize/LoopConvertUtils.cpp test/clang-tidy/modernize-loop-convert-lowercase.cpp test/clang-tidy/modernize-loop-convert-uppercase.cpp Index: tes

Re: [PATCH] D11908: Clang support for -fthinlto.

klimek added a subscriber: klimek. klimek added a comment. Perhaps "sharded" would fit what it is? http://reviews.llvm.org/D11908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13381: Handle trailing underscores on modernize-loop-convert variable namer.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang-tools-extra] r249127 - Handle trailing underscores on modernize-loop-convert variable namer.

Author: angelgarcia Date: Fri Oct 2 08:20:11 2015 New Revision: 249127 URL: http://llvm.org/viewvc/llvm-project?rev=249127&view=rev Log: Handle trailing underscores on modernize-loop-convert variable namer. Summary: https://llvm.org/bugs/show_bug.cgi?id=24961. Reviewers: klimek Subscribers: cf

Re: [PATCH] D13381: Handle trailing underscores on modernize-loop-convert variable namer.

angelgarcia updated this revision to Diff 36357. angelgarcia added a comment. Yes! Sorry. http://reviews.llvm.org/D13381 Files: clang-tidy/modernize/LoopConvertUtils.cpp test/clang-tidy/modernize-loop-convert-lowercase.cpp test/clang-tidy/modernize-loop-convert-uppercase.cpp Index: test/

Re: [PATCH] D13352: [PATCH] Add a CERT category for clang-tidy checkers

klimek added a subscriber: klimek. klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13352 ___ cfe-commits mailing list cfe-commits@li

r249129 - Divide TraverseInitListExpr to a different function for each form.

Author: angelgarcia Date: Fri Oct 2 08:25:51 2015 New Revision: 249129 URL: http://llvm.org/viewvc/llvm-project?rev=249129&view=rev Log: Divide TraverseInitListExpr to a different function for each form. Summary: create TraverseSyntacticInitListExpr and TraverseSemanticInitListExpr. Reviewers:

[clang-tools-extra] r249130 - Adding a new clang-tidy module to house CERT-specific checkers, and map existing checkers to CERT secure coding rules and recommendations for both C (https://www.secureco

Author: aaronballman Date: Fri Oct 2 08:27:19 2015 New Revision: 249130 URL: http://llvm.org/viewvc/llvm-project?rev=249130&view=rev Log: Adding a new clang-tidy module to house CERT-specific checkers, and map existing checkers to CERT secure coding rules and recommendations for both C (https:/

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

On Thu, Oct 01, 2015 at 09:00:46PM +, Alex Rosenberg via cfe-commits wrote: > alexr added a subscriber: alexr. > alexr added a comment. > > PowerPC has floating point hardware by definition. Is this some new variant? e500MC for example only has SPE, not "normal" FPU. Joerg __

Re: [PATCH] D13349: [OpenCL] Casting boolean to an integer vector in OpenCL should set all bits if boolean is true

pekka.jaaskelainen added a comment. OK now. http://reviews.llvm.org/D13349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13352: [PATCH] Add a CERT category for clang-tidy checkers

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r249130. Do we want to have code owners for this sort of thing, or is that too fine-grained of a concept? If we do want them, I am (obviously) happy to be the code owner for anything in the CERT directory.

Re: [PATCH] D13246: Fix bug in modernize-use-nullptr.

angelgarcia updated this revision to Diff 36359. angelgarcia added a comment. Update this patch to the change in RecursiveASTVisitor. http://reviews.llvm.org/D13246 Files: clang-tidy/modernize/UseNullptrCheck.cpp test/clang-tidy/modernize-use-nullptr.cpp Index: test/clang-tidy/modernize-us

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

02.10.2015, 00:00, "Alex Rosenberg via cfe-commits" : > alexr added a subscriber: alexr. > alexr added a comment. > > PowerPC has floating point hardware by definition. Is this some new variant? Some cores from ppc400 series do not have hardware FP (for example, ppc 405) -- Regards, Konstanti

Re: [PATCH] D11908: Clang support for -fthinlto.

tejohnson added a subscriber: tejohnson. tejohnson added a comment. Added echristo, rafael, pcc officially as subscribers as Duncan's cc of them via email didn't stick. http://reviews.llvm.org/D11908 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D11908: Clang support for -fthinlto.

tejohnson added a comment. Sorry for the duplicate - my previous response didn't go to Duncan or Mehdi for some reason. Trying again... In http://reviews.llvm.org/D11908#258540, @klimek wrote: > Perhaps "sharded" would fit what it is? You could have a sharded mode for full FDO (like gcc's par

Re: [PATCH] D13352: [PATCH] Add a CERT category for clang-tidy checkers

I dont think we need finer grained code owners, but I also don't have real objections. On Fri, Oct 2, 2015, 3:31 PM Aaron Ballman wrote: > aaron.ballman closed this revision. > aaron.ballman added a comment. > > Thanks! I've commit in r249130. > > Do we want to have code owners for this sort of

[clang-tools-extra] r249133 - Hopefully rectifying a build bot issue with:

Author: aaronballman Date: Fri Oct 2 09:01:55 2015 New Revision: 249133 URL: http://llvm.org/viewvc/llvm-project?rev=249133&view=rev Log: Hopefully rectifying a build bot issue with: http://bb.pgr.jp/builders/i686-mingw32-RA-on-linux/builds/2833/steps/build_llvmclang/logs/stdio Also, drive-by c

Re: [PATCH] D13352: [PATCH] Add a CERT category for clang-tidy checkers

On Fri, Oct 2, 2015 at 9:59 AM, Manuel Klimek wrote: > I dont think we need finer grained code owners, but I also don't have real > objections. Then we can leave well enough alone. :-) ~Aaron > > > On Fri, Oct 2, 2015, 3:31 PM Aaron Ballman wrote: >> >> aaron.ballman closed this revision. >> a

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

richard.barton.arm added a comment. What do you think about this Renato? Although Alexandros has added a LangOption which is strictly speaking to do with CodeGen rather than Lang, I think this is the only pragmatica way to do this without needing re-engineering work to expose the codegen option

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Sorry, I've been redirected elsewhere for a few days. I agree that this is the best option, since that's the meaning of the flag, anyway. LGTM. --renato http://reviews.llvm.org/D12633

[clang-tools-extra] r249136 - Taking a stab at fixing failing build bots that use make. Unfortunately, the build logs do not point to much useful information for tracking this down, such as:

Author: aaronballman Date: Fri Oct 2 09:28:44 2015 New Revision: 249136 URL: http://llvm.org/viewvc/llvm-project?rev=249136&view=rev Log: Taking a stab at fixing failing build bots that use make. Unfortunately, the build logs do not point to much useful information for tracking this down, such

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

xazax.hun marked 9 inline comments as done. Comment at: lib/StaticAnalyzer/Core/BugId.cpp:29 @@ +28,3 @@ + +static std::string GetSignature(const FunctionDecl *Target) { + if (!Target) zaks.anna wrote: > Can/Should we use some existing machinery for this? For exa

r249137 - Add support for the new mips-mti-linux toolchain.

Author: vkalintiris Date: Fri Oct 2 09:38:23 2015 New Revision: 249137 URL: http://llvm.org/viewvc/llvm-project?rev=249137&view=rev Log: Add support for the new mips-mti-linux toolchain. Summary: This new toolchain uses primarily LLVM-based tools, eg. compiler-rt, lld, libcxx, etc. Because of th

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

This revision was automatically updated to reflect the committed changes. vkalintiris marked an inline comment as done. Closed by commit rL249137: Add support for the new mips-mti-linux toolchain. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D13340?vs=36344&id=363

r249138 - Fix bogus comment.

Author: dougk Date: Fri Oct 2 09:41:38 2015 New Revision: 249138 URL: http://llvm.org/viewvc/llvm-project?rev=249138&view=rev Log: Fix bogus comment. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Dri

r249140 - Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets.

Author: alelab01 Date: Fri Oct 2 09:56:37 2015 New Revision: 249140 URL: http://llvm.org/viewvc/llvm-project?rev=249140&view=rev Log: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets. Differential Revision: http://reviews.llvm.org/D12633 Modified: cfe/trunk

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL249140: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64]… (authored by alelab01). Changed prior to commit: http://reviews.llvm.org/D12633?vs=35628&id=36367#toc Repository: rL

r249141 - Revert "Add support for the new mips-mti-linux toolchain."

Author: vkalintiris Date: Fri Oct 2 10:00:55 2015 New Revision: 249141 URL: http://llvm.org/viewvc/llvm-project?rev=249141&view=rev Log: Revert "Add support for the new mips-mti-linux toolchain." This reverts commit r249137 because it broke the Windows buildbots and a Linux buildbot for LLD. Re

[PATCH] D13386: PR24115: Don't instantiate constexpr function templates in decltype

sberg created this revision. sberg added reviewers: cfe-commits, rsmith. As discussed in [[ https://llvm.org/bugs/show_bug.cgi?id=24115 | "llvm-nm fails to build with gcc 5.1's libstdc++," ]] both llvm-nm and LibreOffice fail to build against GCC 5.1 libstdc++, due to Clang trying (and failing)

r249142 - Make test more resilient to FastIsel changes. NFC.

Author: adibiagio Date: Fri Oct 2 10:10:22 2015 New Revision: 249142 URL: http://llvm.org/viewvc/llvm-project?rev=249142&view=rev Log: Make test more resilient to FastIsel changes. NFC. Currently FastISel doesn't know how to select vector bitcasts. During instruction selection, fast-isel always

r249143 - [DarwinDriver] Reapply: Use -lto_library to specify the path for libLTO.dylib

Author: bruno Date: Fri Oct 2 10:10:33 2015 New Revision: 249143 URL: http://llvm.org/viewvc/llvm-project?rev=249143&view=rev Log: [DarwinDriver] Reapply: Use -lto_library to specify the path for libLTO.dylib Reapply r248935. Usually, when using LTO with a clang installation newer than the syst

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

sbenza added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-static-cast-downcast.cpp:19 @@ +18,3 @@ + // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: do not use static_cast to cast from base to derived. Use dynamic_cast instead. (C++ Core Guidelines, rule

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

sbenza added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:38 @@ +37,3 @@ + Finder->addMatcher( + arraySubscriptExpr(hasBase(implicitCastExpr(hasSourceExpression( + hasType(pointerType()).bind("e

Re: [PATCH] D12901: [Static Analyzer] Intersecting ranges and 64 bit to 32 bit truncations causing "System is over constrained." assertions.

pgousseau added a comment. Ping ! http://reviews.llvm.org/D12901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11908: Clang support for -fthinlto.

klimek added a comment. In http://reviews.llvm.org/D11908#258570, @tejohnson wrote: > Sorry for the duplicate - my previous response didn't go to Duncan or Mehdi > for some reason. Trying again... > > In http://reviews.llvm.org/D11908#258540, @klimek wrote: > > > Perhaps "sharded" would fit what

Re: [PATCH] D13368: [clang-tidy] add check cppcoreguidelines-pro-type-static-cast-downcast

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.cpp:33 @@ +32,3 @@ + + SubExpr = SubExpr->IgnoreParens(); + QualType SourceType = SubExpr->getType(); Will the type dependence check also look through pa

Re: [PATCH] D13246: Fix bug in modernize-use-nullptr.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D11908: Clang support for -fthinlto.

On Fri, Oct 2, 2015 at 9:44 AM, Teresa Johnson via cfe-commits < cfe-commits@lists.llvm.org> wrote: As David mentioned, "inlineonly" is much too restrictive for what is > possible. I prefer to stick with "thin" since it refers to this new model > of keeping the whole program part very thin. > Agr

Re: [PATCH] D11908: Clang support for -fthinlto.

On Fri, Oct 2, 2015 at 8:53 AM, Manuel Klimek wrote: > klimek added a comment. > > In http://reviews.llvm.org/D11908#258570, @tejohnson wrote: > >> Sorry for the duplicate - my previous response didn't go to Duncan or Mehdi >> for some reason. Trying again... >> >> In http://reviews.llvm.org/D119

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

zaks.anna added a comment. > Generating mangled names requires ASTContext which is not available during > the error reporting. BugReporter does have the ASTContext, so it would not > be a big change to add it to the DiagnosticConsumers though. And I think the > mangled name might contain too

[PATCH] D13388: Add support for querying the visibility of a cursor

michaelwu created this revision. michaelwu added a subscriber: cfe-commits. This patch implements clang_getCursorVisibility which provides access to NamedDecl::getVisibility. It's been very useful for me when generating bindings. http://reviews.llvm.org/D13388 Files: include/clang-c/Index.h

Re: [PATCH] D13311: [clang-tidy] Add check cppcoreguidelines-pro-bounds-pointer-arithmetic

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:48 @@ +47,3 @@ + diag(MatchedExpr->getExprLoc(), + "do not use pointer arithmetic (C++ Core Guidelines, rule Bounds.1)"); +} Can elide the pare

r249148 - [OpenMP] Target directive host codegen.

Author: sfantao Date: Fri Oct 2 11:14:20 2015 New Revision: 249148 URL: http://llvm.org/viewvc/llvm-project?rev=249148&view=rev Log: [OpenMP] Target directive host codegen. This patch implements the outlining for offloading functions for code annotated with the OpenMP target directive. It uses

Re: [PATCH] D12871: [OpenMP] Target directive host codegen - rebased

sfantao closed this revision. sfantao added a comment. Committed in r249148! Thanks, Samuel http://reviews.llvm.org/D12871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

mgehre updated this revision to Diff 36371. mgehre added a comment. Rebased Removed "(C++ Core Guidelines, rule Type.1)" from diagnostic Can someone please commit this? http://reviews.llvm.org/D13313 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/add_new_check.py clang

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

mgehre updated this revision to Diff 36372. mgehre added a comment. Shot to fast, fixed test. Now it's ready http://reviews.llvm.org/D13313 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/add_new_check.py clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreg

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

aaron.ballman added a comment. Does not apply cleanly to ToT; can you rebase? ~Aaron http://reviews.llvm.org/D13313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r249152 - constify ClassTemplatePartialSpecializationDecl::getInstantiatedFromMember and VarTemplatePartialSpecializationDecl::getInstantiatedFromMember.

Author: yrnkrn Date: Fri Oct 2 11:40:48 2015 New Revision: 249152 URL: http://llvm.org/viewvc/llvm-project?rev=249152&view=rev Log: constify ClassTemplatePartialSpecializationDecl::getInstantiatedFromMember and VarTemplatePartialSpecializationDecl::getInstantiatedFromMember. Modified: cfe/

Re: r249141 - Revert "Add support for the new mips-mti-linux toolchain."

The regular expression should match match clang.exe on Windows. 2015-10-02 18:00 GMT+03:00 Vasileios Kalintiris via cfe-commits < cfe-commits@lists.llvm.org>: > Author: vkalintiris > Date: Fri Oct 2 10:00:55 2015 > New Revision: 249141 > > URL: http://llvm.org/viewvc/llvm-project?rev=249141&vi

RE: r249141 - Revert "Add support for the new mips-mti-linux toolchain."

Thanks Yaron. I'll to figure out what's going wrong with the Linux buildbot and I'll re-commit the fixed patch tomorrow. - Vasileios From: Yaron Keren [yaron.ke...@gmail.com] Sent: 02 October 2015 17:46 To: Vasileios Kalintiris Cc: cfe-commits Subject: Re: r249141

r249154 - [OpenMP] Capture global variables in target regions.

Author: sfantao Date: Fri Oct 2 12:14:03 2015 New Revision: 249154 URL: http://llvm.org/viewvc/llvm-project?rev=249154&view=rev Log: [OpenMP] Capture global variables in target regions. All global variables that are not enclosed in a declare target region must be captured in the target region a

Re: [PATCH] D12262: [OpenMP] Capture global variables in target regions.

sfantao closed this revision. sfantao added a comment. Committed in r249154. Thanks! Samuel http://reviews.llvm.org/D12262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow updated this revision to Diff 36373. wristow added a comment. Added 4 new tests, the verify the last -fdeclspec/-fno-declspec wins, both in the context of -fms-extensions and without -fms-extensions. http://reviews.llvm.org/D13322 Files: include/clang/Basic/LangOptions.def include/

Re: [PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow added inline comments. Comment at: lib/Driver/Tools.cpp:4663 @@ +4662,3 @@ + else if (Args.hasArg(options::OPT_fno_declspec)) +CmdArgs.push_back("-fno-declspec"); // Explicitly disabling __declspec. + But in the '-fno-declspec -fdeclspec' case, the 'i

LLVM buildnaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Sorry for the noise. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r249156 - Break long lines for readability.

Author: adrian Date: Fri Oct 2 12:36:10 2015 New Revision: 249156 URL: http://llvm.org/viewvc/llvm-project?rev=249156&view=rev Log: Break long lines for readability. Modified: cfe/trunk/test/Modules/ModuleDebugInfo.m Modified: cfe/trunk/test/Modules/ModuleDebugInfo.m URL: http://llvm.org/v

r249155 - Remove unused variable.

Author: adrian Date: Fri Oct 2 12:36:03 2015 New Revision: 249155 URL: http://llvm.org/viewvc/llvm-project?rev=249155&view=rev Log: Remove unused variable. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/llvm-proje

r249157 - Module debugging: Don't emit forward declarations in module scopes.

Author: adrian Date: Fri Oct 2 12:36:14 2015 New Revision: 249157 URL: http://llvm.org/viewvc/llvm-project?rev=249157&view=rev Log: Module debugging: Don't emit forward declarations in module scopes. A forward declaration inside a module header does not belong to the module. Modified: cfe/tr

r249159 - constify four getInstantiatedFromMemberTemplate() in DeclTemplate.h.

Author: yrnkrn Date: Fri Oct 2 12:38:57 2015 New Revision: 249159 URL: http://llvm.org/viewvc/llvm-project?rev=249159&view=rev Log: constify four getInstantiatedFromMemberTemplate() in DeclTemplate.h. Modified: cfe/trunk/include/clang/AST/DeclTemplate.h Modified: cfe/trunk/include/clang/AS

Re: [PATCH] D13217: [ARM] The Driver does not set the +strict-align flag when targeting armv6m + netbsd

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4456 @@ -4455,3 +4455,1 @@ -if (ArchVersion < 6 || - (ArchVersion == 6 && ArchProfile == llvm::ARM::PK_M)) Why is this not necessary any more? http://reviews.llvm.org/D13217 _

Re: [PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

Prazek updated the summary for this revision. Prazek updated this revision to Diff 36382. Prazek marked an inline comment as done. http://reviews.llvm.org/D13373 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/invariant.group-for-vptrs.cpp test/CodeGenCXX/strict-vtable-pointers.cpp Index: t

Re: [PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, but your commit message should be more descriptive than your current summary. Something like: Ensure that the vptr store in the most-derived constructor is not behind an invariant group

r249166 - [Myriad]: Accept '-nostdlib' option

Author: dougk Date: Fri Oct 2 13:39:08 2015 New Revision: 249166 URL: http://llvm.org/viewvc/llvm-project?rev=249166&view=rev Log: [Myriad]: Accept '-nostdlib' option Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/lib/Driver/Tools.c

Re: [PATCH] D12508: [libcxx] Make it drastically simpler to link libc++.

EricWF added a comment. @mclow.lists ping. Do you think this is the right approach to fix linking the ABI library? @rsmith: I think you asked for this functionality a while ago. Any thoughts? http://reviews.llvm.org/D12508 ___ cfe-commits mailing l

Question about FunctionDecl::isVariadic()

Given the following two function declarations: void f1(...); void f2(); It makes sense to me that isVariadic() returns true for f1 in both C and C++. It makes sense to me that isVariadic() returns false for f2 in C++. I am confused as to why it returns false instead of true for C, however. In C1

r249176 - [WebAssembly] Add a __builtin_wasm_memory_size() intrinsic.

Author: djg Date: Fri Oct 2 14:38:47 2015 New Revision: 249176 URL: http://llvm.org/viewvc/llvm-project?rev=249176&view=rev Log: [WebAssembly] Add a __builtin_wasm_memory_size() intrinsic. Modified: cfe/trunk/include/clang/Basic/BuiltinsWebAssembly.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp

Re: Question about FunctionDecl::isVariadic()

Since "varargs" often involve some kind of special passing mechanisms [I've seen implementations that build data block and pass a pointer to that, rather than passing on the stack, for example], or additional code in the recipient function, I would say that `f2()` does not mean `f2(...)`. -- Mats

r249179 - [WebAssembly] Add a __builtin_wasm_resize_memory() intrinsic.

Author: djg Date: Fri Oct 2 15:20:01 2015 New Revision: 249179 URL: http://llvm.org/viewvc/llvm-project?rev=249179&view=rev Log: [WebAssembly] Add a __builtin_wasm_resize_memory() intrinsic. Modified: cfe/trunk/include/clang/Basic/BuiltinsWebAssembly.def cfe/trunk/lib/CodeGen/CGBuiltin.c

Re: [PATCH] D10370: clang-format: Implement AlwaysBreakAfterDeclarationReturnType.

dawn added a subscriber: dawn. dawn added a comment. Can someone please accept and commit this patch so we can use this feature? Thanks. http://reviews.llvm.org/D10370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: [libcxx] r248313 - Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

Hi Tom, I would like this patch merged into 3.7.1. Marshall can you please approve this? /Eric On Tue, Sep 22, 2015 at 12:55 PM, Dimitry Andric via cfe-commits wrote: > Author: dim > Date: Tue Sep 22 13:55:37 2015 > New Revision: 248313 > > URL: http://llvm.org/viewvc/llvm-project?rev=248313&vi

Re: Question about FunctionDecl::isVariadic()

On Fri, Oct 2, 2015 at 4:01 PM, mats petersson wrote: > Since "varargs" often involve some kind of special passing mechanisms [I've > seen implementations that build data block and pass a pointer to that, > rather than passing on the stack, for example], or additional code in the > recipient funct

Re: [PATCH] D13157: Teach -Wtautological-overlap-compare about enums

On Fri, Oct 2, 2015 at 6:10 AM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Oct 1, 2015 at 5:18 PM, Richard Trieu wrote: > > I'm in favor of keeping the asserts around. Several times, I've seen > Clang > > crashers than languish in the bug tracker with an assert

Re: [PATCH] D13337: [libcxx] Attempt to fix __throw_future_error in C++03

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. I can't reproduce the error that I was getting. http://reviews.llvm.org/D13337 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

This seems a little curious, so you'll have code like this: decl foo module def bar member foo pointer (references the declaration of foo outside the module, in the CU?) Why is that preferable to DWARF that looks more like the AST where the declaration of foo appears in the first m

Re: Question about FunctionDecl::isVariadic()

On 2 October 2015 at 22:07, Aaron Ballman wrote: > On Fri, Oct 2, 2015 at 4:01 PM, mats petersson > wrote: > > Since "varargs" often involve some kind of special passing mechanisms > [I've > > seen implementations that build data block and pass a pointer to that, > > rather than passing on the s

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

mgehre updated this revision to Diff 36399. mgehre added a comment. rebased http://reviews.llvm.org/D13313 Files: clang-tidy/CMakeLists.txt clang-tidy/Makefile clang-tidy/add_new_check.py clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyMod

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

mgehre added a comment. I'm not sure what you mean by ToT. I rebased this against master @ http://llvm.org/git/clang-tools-extra.git http://reviews.llvm.org/D13313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[libcxx] r249192 - [libcxx] Attempt to fix __throw_future_error in C++03

Author: ericwf Date: Fri Oct 2 16:25:15 2015 New Revision: 249192 URL: http://llvm.org/viewvc/llvm-project?rev=249192&view=rev Log: [libcxx] Attempt to fix __throw_future_error in C++03 Summary: Hi Marshall, Could you please test this patch and see if you run into the same linker errors we ta

Re: Question about FunctionDecl::isVariadic()

On Fri, Oct 2, 2015 at 5:22 PM, mats petersson wrote: > > > On 2 October 2015 at 22:07, Aaron Ballman wrote: >> >> On Fri, Oct 2, 2015 at 4:01 PM, mats petersson >> wrote: >> > Since "varargs" often involve some kind of special passing mechanisms >> > [I've >> > seen implementations that build d

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

> On Oct 2, 2015, at 2:18 PM, David Blaikie wrote: > > This seems a little curious, so you'll have code like this: > > decl foo > module > def bar >member foo pointer (references the declaration of foo outside the > module, in the CU?) > Right. > Why is that preferable to DW

Re: [PATCH] D13313: [clang-tidy] new check cppcoreguidelines-pro-type-reinterpret-cast

On Fri, Oct 2, 2015 at 5:27 PM, Matthias Gehre wrote: > mgehre added a comment. > > I'm not sure what you mean by ToT. I rebased this against master @ > http://llvm.org/git/clang-tools-extra.git Top of Tree from the svn repository. I'm not certain how quickly the git mirror updates, but when I d

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote: > > On Oct 2, 2015, at 2:18 PM, David Blaikie wrote: > > This seems a little curious, so you'll have code like this: > > decl foo > module > def bar >member foo pointer (references the declaration of foo outside the > module, i

Re: r249157 - Module debugging: Don't emit forward declarations in module scopes.

> On Oct 2, 2015, at 2:58 PM, David Blaikie wrote: > > > > On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl > wrote: > >> On Oct 2, 2015, at 2:18 PM, David Blaikie > > wrote: >> >> This seems a little curious, so you'll have code like this:

  1   2   >