On Tue, Aug 06, 2013 at 07:05:30PM +0200, Carsten Mattner wrote: > Minimally off-topic but I'm sure everyone will agree that d_termname's > size should be increased to prevent problems with things like > TERM=rxvt-unicode-256color. Maybe like this? > --- a/src/display.h > +++ b/src/display.h > @@ -73,7 +73,7 @@ struct display > struct win *d_other; /* pointer to other window */ > int d_nonblock; /* -1 don't block if obufmax reached */ > /* >0: block after nonblock secs */ > - char d_termname[20 + 1]; /* $TERM */ > + char d_termname[24 + 1]; /* $TERM */ > char *d_tentry; /* buffer for tgetstr */ > char d_tcinited; /* termcap inited flag */ > int d_width, d_height; /* width/height of the screen */
That definitely doesn't suffice. There are several places where this needs to be changed. Also I think if we change that value, it should be changed with more farsight and not only extended by 4 bytes. The Debian packagedoubled the size and uses 40 bytes for that. Full patch at http://patch-tracker.debian.org/patch/series/view/screen/4.1.0~20120320gitdb59704-9/50increase-max-TERM-length.patch (May require other Debian patches, at least for correct line numbers, and hence not apply cleanly.) All patches used in the Debian package: http://patch-tracker.debian.org/package/screen/4.1.0~20120320gitdb59704-9 Kind regards, Axel -- /~\ Plain Text Ribbon Campaign | Axel Beckert \ / Say No to HTML in E-Mail and News | a...@deuxchevaux.org (Mail) X See http://www.asciiribbon.org/ | a...@noone.org (Mail+Jabber) / \ I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web) _______________________________________________ screen-users mailing list screen-users@gnu.org https://lists.gnu.org/mailman/listinfo/screen-users
