On Sat, Mar 21, 2026 at 4:58 AM Tobias Wendorff < [email protected]> wrote:
> Hello everyone, > > some time ago, I submitted a patch that fixes a breaking issue: > https://savannah.gnu.org/bugs/?68139 > > Summary: In GNU Screen 5.0.x, deattaching an attached session (dangling > in an disconnected ssh session) fails with a "Cannot find terminfo entry > for ''" error. This happens because the server incorrectly routes detach > requests through the attach initialization path instead of the proper > detach path. > > I have tested this on multiple systems, and it resolves the problem in > all cases. Could someone please take a look and let me know whether it > is suitable for inclusion in the repository, or if there is anything I > should improve? Do in need to sign anything, as in other projects? > > Just to clarify: My main goal is to help others get rid of this issue, > not to force this into the repository. Adoption of the 5.x series is > still quite low (Debian, where are you??), even though it brings some > extremely important improvements - and we probably do not want tmux and > shpool to keep overtaking, right? :D > > Best regards, > Tobias > > Hello, I had a chance to look at your patch. Thanks for digging into this! I tested your patch against the tip of the `screen-v5` branch (specifically, commit dfd4b4b0b297367d5f7a6c40b4b1ecfb5eb4a2a4) as I think that's where current development is happening (someone feel free to correct me if I'm wrong!). I can confirm that the bug was present before the patch and gone after the patch. I also noticed you added a test (hooray!) that uses `script` to attach to a screen session from a new controlling TTY (I never knew about this behaviour for script but looks like a good solution). Your exec of `script` tells it to use a temp file for its output which is nice because we won't litter "typescript" files when running the test. We don't seem to read the output, however, so maybe we could use /dev/null instead of creating and removing a temp file? WDYT? Thanks again! - Tom
