URL:
  <http://gna.org/bugs/?func=detailitem&item_id=5000>

                 Summary: sv_extra_viewcvs_forbidden doesn't work exactly
                 Project: Savane
            Submitted by: rudy
            Submitted on: Thursday 01/05/2006 at 17:28
                Category: Backend
                Priority: C - Normal
                Severity: 3 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Planned Release: 

    _______________________________________________________

Details:

When having private projects the forbidden line in viewcvs.conf gets double
values.

Also the scripts goes out from the fact that the exact syntax of the
forbidden line is:

"forbidden = "

This latter comes because the regular expression that matches in the config
file matches on: /^forbidden = (.*)$/. This could be fixed so that it matches
on /^forbidden =\s*(.*)$/

For the former.  When running the script starting with an empty forbidden
line the script produces the following forbidden line:
"forbidden =  projectname"
Notice the two spaces after the equal sign.

When running the script again time the forbidden line becomes: 
"forbidden =   projectname, projectname"
Now we have three white spaces.

Removing this double entry and the extra spaces can be done with the
following patch.  I simply removes an single space.

181c181
<     s/^forbidden \= (.*)$/forbidden = $forbidden_groups/g;
---
>     s/^forbidden \= (.*)$/forbidden =$forbidden_groups/g;







    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?func=detailitem&item_id=5000>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Savane-dev mailing list
[email protected]
https://mail.gna.org/listinfo/savane-dev

Reply via email to