Hi,

I have just submitted rssh package for the official Fedora repository at

https://bugzilla.redhat.com/show_bug.cgi?id=456182

I found that the upstream spec uses the broken %makeinstall macro which is not recommended by Fedora for reasons outlined in

https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

The recommended alternative failed with the error at

http://fpaste.org/paste/3774

This is because of the incorrectly hardcoded path in the makefile. I have a patch applied for this in the package I submitted. The relevant makefile patch that fixes the issue is attached. Please apply. Thanks.

Rahul


--- rssh-2.3.2/Makefile.am.old  2008-07-21 19:58:59.000000000 -0400
+++ rssh-2.3.2/Makefile.am      2008-07-21 19:59:05.000000000 -0400
@@ -16,7 +16,7 @@
        $(CC) -c $(DEFS) $(ourdefs) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $<
 
 install-exec-hook:
-       chmod u+s $(libexecdir)/rssh_chroot_helper
+       chmod u+s $(DESTDIR)$(libexecdir)/rssh_chroot_helper
 
 rpm:   dist
        rpmbuild -ta --sign $(base).tar.gz
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
rssh-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rssh-discuss

Reply via email to