@dmnks requested changes on this pull request.
Just a couple of nitpicks remaining, see the inline comments.
> @@ -10,6 +10,10 @@ rpmspec - RPM Spec Tool
*rpmspec* *--shell* [options] [_SPEC_FILE_ ...]
+*rpmspec* *--sources* [options] [_SPEC_FILE_ ...]
```suggestion
*rpmspec* *--sources* [options] [list-options] _SPEC_FILE_ ...
```
With these operations, a spec file argument is actually required, hence the
removed square brackets.
> @@ -10,6 +10,10 @@ rpmspec - RPM Spec Tool
*rpmspec* *--shell* [options] [_SPEC_FILE_ ...]
+*rpmspec* *--sources* [options] [_SPEC_FILE_ ...]
+
+*rpmspec* *--patches* [options] [_SPEC_FILE_ ...]
Same as above
> @@ -34,6 +38,14 @@ generated during a build of a package like auto generated
> dependencies.
Invoke an interactive shell for inspecting macros, optionally
after parsing a spec. Mainly useful for troubleshooting.
+*--sources*
+ List all source files defined in the spec file(s).
```suggestion
List all source files defined in the spec file(s), one file per line.
```
> @@ -34,6 +38,14 @@ generated during a build of a package like auto generated
> dependencies.
Invoke an interactive shell for inspecting macros, optionally
after parsing a spec. Mainly useful for troubleshooting.
+*--sources*
+ List all source files defined in the spec file(s).
+ Output separated by newlines.
+
+*--patches*
+ List all patch files defined in the spec file(s).
+ Output separated by newlines.
Same as above
> @@ -34,6 +38,14 @@ generated during a build of a package like auto generated
> dependencies.
Invoke an interactive shell for inspecting macros, optionally
after parsing a spec. Mainly useful for troubleshooting.
+*--sources*
+ List all source files defined in the spec file(s).
+ Output separated by newlines.
This can be dropped when the above is applied.
> @@ -34,6 +38,14 @@ generated during a build of a package like auto generated
> dependencies.
Invoke an interactive shell for inspecting macros, optionally
after parsing a spec. Mainly useful for troubleshooting.
+*--sources*
+ List all source files defined in the spec file(s).
This is really nitpicky and cosmetic, but follows the general writing style of
our man pages better...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4262#pullrequestreview-4787395998
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4262/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
