The STL conversion changed file trigger ordering from descending to ascending
priority even though larger priority values are documented to execute first.
This changes ordering-dependent transaction results and can make the intended
final trigger result disappear.

Restore the original descending priority comparison while retaining ascending
header and trigger-index tie breakers. Add regression coverage that installs a
trigger owner and matching data package in one transaction and verifies that
both immediate transaction file triggers run in priority order.

Fixes: #4254

Signed-off-by: Daan De Meyer <[email protected]>

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/4276

-- Commit Summary --

  * Restore file trigger priority ordering

-- File Changes --

    M lib/rpmtriggers.hh (5)
    A tests/data/SPECS/filetrigger-priority.spec (30)
    M tests/rpmscript.at (20)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/4276.patch
https://github.com/rpm-software-management/rpm/pull/4276.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4276
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/[email protected]>
_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to