@dralley commented on this pull request.
> @@ -568,15 +568,15 @@ static int regionSwab(indexEntry entry, int il, int dl,
}
} break;
case RPM_INT32_TYPE:
- { int32_t * it = ie.data;
+ { uint32_t * it = ie.data;
See the INT64 type handling above. Additionally `htonll()`, `htonl()`, and
`htons()` all work with unsigned integers so the casting as signed integers,
while probably innocuous, is confusing.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2316#pullrequestreview-1210209539
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2316/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
http://lists.rpm.org/mailman/listinfo/rpm-maint
