Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24096 )
Change subject: KUDU-3692 Export entity attributes as Prometheus labels ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24096/3/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/24096/3/src/kudu/util/metrics.cc@1226 PS3, Line 1226: SubstituteAndAppend(&out, kSumCountFmt, : prefix, count_name, label_prefix, unit, h.TotalCount()); It seems this code generates incorrect unit for the summary count. In the example below, it states the unit is 'microseconds' when instead it should have been 'units' or similar: # HELP kudu_log_append_latency_count Microseconds spent on appending to the log segment file (count) # TYPE kudu_log_append_latency_count counter kudu_log_append_latency_count{type="tablet",id="3e4ba2a0e3ea4c548b1aed2da8636058",table_id="b351f79cf4cd453fb71b9c1635408242",table_name="default.loadgen_auto_c806e4ae4d664ae7848bbc754de48cff",unit_type="microseconds"} 4 Please fix this and add a test scenario to make sure it's fixed and cover future regressions, if any. -- To view, visit http://gerrit.cloudera.org:8080/24096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I690918d06f19c393369b8fc43c3ec90dd2231d3d Gerrit-Change-Number: 24096 Gerrit-PatchSet: 3 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Wed, 18 Mar 2026 21:41:07 +0000 Gerrit-HasComments: Yes
