Yan-Daojiang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23844 )

Change subject: [tools] Add --preserve_table_ids flag to unsafe_rebuild
......................................................................


Patch Set 9:

(1 comment)

> Patch Set 6:
>
> (1 comment)

Thanks for the review! I agree that this parameter should be enabled by 
default. I've updated the patch and revised the commit message accordingly.

PTAL when you have time. Thanks!

http://gerrit.cloudera.org:8080/#/c/23844/6/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:

http://gerrit.cloudera.org:8080/#/c/23844/6/src/kudu/tools/kudu-admin-test.cc@4093
PS6, Line 4093:     ASSERT_GE(row_count, 10) << "Should be able to scan table 
before rebuil
> nit for here and below: since this log line doesn't help with the automated
DONE



--
To view, visit http://gerrit.cloudera.org:8080/23844
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ae4353564922312d646f0323271d804e32e3b0d
Gerrit-Change-Number: 23844
Gerrit-PatchSet: 9
Gerrit-Owner: Yan-Daojiang <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yan-Daojiang <[email protected]>
Gerrit-Comment-Date: Fri, 13 Mar 2026 09:07:12 +0000
Gerrit-HasComments: Yes

Reply via email to