Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23844 )
Change subject: [tools] Add --preserve_table_ids flag to unsafe_rebuild ...................................................................... Patch Set 6: > Patch Set 6: Code-Review+1 > > (1 comment) > > Overall looks good to me. > If you can address the question I have raised, that would be great! Thanks for raising this concern, that’s a good point. As you mentioned, this could be a concern in the case of a security incident where previously issued tokens should be invalidated. In such cases, using the preserve_table_ids flag would not be appropriate. My understanding is that this flag is mainly intended for recovery scenarios where preserving table ids is desirable to avoid client-side inconsistencies. Maybe we could document that it should not be used in situations where token invalidation is required after a security incident. -- To view, visit http://gerrit.cloudera.org:8080/23844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ae4353564922312d646f0323271d804e32e3b0d Gerrit-Change-Number: 23844 Gerrit-PatchSet: 6 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Fri, 06 Mar 2026 10:08:03 +0000 Gerrit-HasComments: No
