Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23521 )
Change subject: KUDU-1261 Add HMS integration for array datatype ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23521/1/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/23521/1/src/kudu/hms/hms_catalog.cc@359 PS1, Line 359: const TypeInfo* elem_type_info = GetArrayElementTypeInfo(*type_info); : DCHECK(elem_type_info); : const DataType elem_type = elem_type_info->type(); : // Kudu only supports 1D arrays of scalar types currently. : DCHECK_NE(elem_type, NESTED) << "nested arrays are not supported"; : const string elem_type_ > Consider using GetArrayElementTypeInfo(*type_info) instead of this. Ah yes, thanks! Done. -- To view, visit http://gerrit.cloudera.org:8080/23521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab1d4c0920043c213757d35ea7bf721a06e8cf44 Gerrit-Change-Number: 23521 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 17:37:33 +0000 Gerrit-HasComments: Yes
