Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23429 )
Change subject: OpenSSL 3.x compatibility adaptation ...................................................................... Patch Set 12: (5 comments) > Patch Set 9: > > (5 comments) > > Almost there. Please address compilation failure on Ubuntu24.04 LTS with > OpenSSL 3.0.13 and a few style nits. > > Thanks a lot for updating the patch! Thanks for the review! This build failure occurs on Ubuntu 24.04 LTS with OpenSSL 3.0.13. The function OSSL_PARAM_BLD_free() is not declared unless <openssl/param_build.h> is explicitly included. Adding this include under the OpenSSL 3.x section resolves the issue. To address the iwyu, I have also made some adjustments to the other header includes. http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/security/crypto.cc File src/kudu/security/crypto.cc: http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/security/crypto.cc@359 PS9, Line 359: #else > nit: move this and same return statement at line 373 out of the #if ... #el Done http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/jwt-util.cc File src/kudu/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/jwt-util.cc@503 PS9, Line 503: return ToString(&pub_key, DataFormat::PEM, rsa.get()); > style/readability nit for here and elsewhere for page-long #if ... #else .. Done http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/jwt-util.cc@613 PS9, Line 613: // Common BIGNUMs for both OpenSSL branches : auto x = bn_from_bytes(ascii_x); > nit: these two lines and lines 684-685 are exactly the same; maybe move the Done http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/jwt-util.cc@669 PS9, Line 669: // > style nit: since it's a continuation of previous line, add two more spaces Done http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/openssl_util.h File src/kudu/util/openssl_util.h: http://gerrit.cloudera.org:8080/#/c/23429/9/src/kudu/util/openssl_util.h@226 PS9, Line 226: > This doesn't compile on Ubuntu24.04 LTS: This build failure occurs on Ubuntu 24.04 LTS with OpenSSL 3.0.13 because OSSL_PARAM_BLD_free() is not declared unless <openssl/param_build.h> is explicitly included ```bash root@b1b8c8a5e612:/home/yandaojiang# grep -R "OSSL_PARAM_BLD_free" /usr/include/openssl/* /usr/include/openssl/param_build.h:void OSSL_PARAM_BLD_free(OSSL_PARAM_BLD *bld); ``` Adding that include under the OpenSSL 3.x section fixes the issue. -- To view, visit http://gerrit.cloudera.org:8080/23429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic587a85e6b9088ffd353f9119b75431f1ec60b5c Gerrit-Change-Number: 23429 Gerrit-PatchSet: 12 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Mon, 13 Oct 2025 07:38:30 +0000 Gerrit-HasComments: Yes
