Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23482 )
Change subject: KUDU-1261 [Java] Add write support for Array Type ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/23482/5/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java: http://gerrit.cloudera.org:8080/#/c/23482/5/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@46 PS5, Line 46: > the following methods are not used anywhere: Yes, they are not needed. Removed them http://gerrit.cloudera.org:8080/#/c/23482/5/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@97 PS5, Line 97: > Why is this cast necessary? The generated Int8Array generated class already Good catch, fixed it. http://gerrit.cloudera.org:8080/#/c/23482/5/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@116 PS5, Line 116: Valid(i > same question as above, it this cast necessary? Good catch, fixed it. http://gerrit.cloudera.org:8080/#/c/23482/5/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@207 PS5, Line 207: > UInt8Array.values() returns an int, so this cast is only safe if the value Fixed it with a better implementation. http://gerrit.cloudera.org:8080/#/c/23482/5/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@233 PS5, Line 233: rArray.Int16Array > this method shows up as unused, is it needed in this change? Yes not needed, removed it. http://gerrit.cloudera.org:8080/#/c/23482/5/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@285 PS5, Line 285: co > I'm seeing a lot of code repetition in this switch-case, maybe consider ext Done -- To view, visit http://gerrit.cloudera.org:8080/23482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe5e243eafe12a8977d40204dacab99624451eb Gerrit-Change-Number: 23482 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 03 Oct 2025 06:55:01 +0000 Gerrit-HasComments: Yes
