Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23484 )
Change subject: KUDU-1261 instantiate SetArray templates in C++ client library ...................................................................... KUDU-1261 instantiate SetArray templates in C++ client library Since Kudu C++ client API still officially supports C++98, it's necessary to have template instantiations for KuduPartialRow::SetArray, KuduPartialRow::Set used in non-array setters. Otherwise, there might be linker errors: see [1] for details. This is a follow-up to [2]. [1] https://isocpp.org/wiki/faq/templates#separate-template-fn-defn-from-decl [2] https://github.com/apache/kudu/commit/5db5af1de Change-Id: I26b923c57213ca3bb6ae77fab4b8ca0e45c8e0e3 Reviewed-on: http://gerrit.cloudera.org:8080/23484 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/common/partial_row.cc 1 file changed, 140 insertions(+), 0 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I26b923c57213ca3bb6ae77fab4b8ca0e45c8e0e3 Gerrit-Change-Number: 23484 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
