Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23481 )
Change subject: KUDU-1261 [Java] Implement serdes of Array Type column ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/23481/1/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java: http://gerrit.cloudera.org:8080/#/c/23481/1/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@282 PS1, Line 282: style nit for here and below: shouldn't this be on a separate line? http://gerrit.cloudera.org:8080/#/c/23481/1/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@290 PS1, Line 290: nit: do lint tools accept this? I'd think continue is expected to be at a separate line http://gerrit.cloudera.org:8080/#/c/23481/3/java/settings.gradle File java/settings.gradle: http://gerrit.cloudera.org:8080/#/c/23481/3/java/settings.gradle@26 PS3, Line 26: "kudu-flatbuffers" What is it? Is something missing in the latest submission? I don't see anything under java/kudu-flatbuffers in PS3 of this review item. -- To view, visit http://gerrit.cloudera.org:8080/23481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1ad9f65fe94c8662ed0e0834ce849e078fc72d2 Gerrit-Change-Number: 23481 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 01 Oct 2025 22:27:35 +0000 Gerrit-HasComments: Yes
