Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23479 )
Change subject: KUDU-1261 make DICT_ENCODING work for string array cells ...................................................................... KUDU-1261 make DICT_ENCODING work for string array cells By implementing the subj, this changelist also addresses corresponding TODO in cfile-test.cc. This patch also adds unit-level tests for the following recently modified/introduced BlockBuilder's methods: * IsBlockFull() * SetBlockFullMasked() * IsBlockFullMasked() This is a follow-up to 9a1c19fd0853aef54bdd52af69194ee43f2a33b6. Change-Id: I290a73d15c53f58e30cd1d63b7025f6cd1f73474 Reviewed-on: http://gerrit.cloudera.org:8080/23479 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/cfile/binary_dict_block.cc M src/kudu/cfile/binary_dict_block.h M src/kudu/cfile/block_encodings.h M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/encoding-test.cc 5 files changed, 174 insertions(+), 16 deletions(-) Approvals: Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I290a73d15c53f58e30cd1d63b7025f6cd1f73474 Gerrit-Change-Number: 23479 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
