Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23474 )
Change subject: KUDU-1261 add GetArray/SetArray C++ client API ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/23474/3/src/kudu/common/partial_row.cc File src/kudu/common/partial_row.cc: http://gerrit.cloudera.org:8080/#/c/23474/3/src/kudu/common/partial_row.cc@189 PS3, Line 189: col_schema.type_info()->name() > Should this be be eti->name() Done http://gerrit.cloudera.org:8080/#/c/23474/3/src/kudu/common/partial_row.cc@244 PS3, Line 244: owership > nit: ownership Done http://gerrit.cloudera.org:8080/#/c/23474/3/src/kudu/common/partial_row.cc@639 PS3, Line 639: return Status::NotSupported("not implemented yet") > Does this need to be present in the commit message if we do not support thi This is already implemented actually: I'm not sure what I haven't updated the setter that uses col_idx. Thanks for pointing at this -- fixed. -- To view, visit http://gerrit.cloudera.org:8080/23474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idba29337563cefefa8cf1000663ec7e27885cb6f Gerrit-Change-Number: 23474 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Sun, 28 Sep 2025 05:18:24 +0000 Gerrit-HasComments: Yes
