Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6 ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23411/2/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/23411/2/src/kudu/server/server_base.cc@620 PS2, Line 620: static bool ValidateIPConfigMode() { : return FLAGS_ip_config_mode == "ipv4" || : FLAGS_ip_config_mode == "ipv6" || : FLAGS_ip_config_mode == "dual"; : } : GROUP_FLAG_VALIDATOR(ip_config_mode, ValidateIPConfigMode); > I’ve looked at server_base, and there seems to be a pattern for such valida Thanks for the inputs. I don't think enums are required anymore in the latest PS. At this point, there are a couple of places (mini master and webserver) only where flag value is checked. Adding enums will add more code and that will still enum checks. As far as validation is concerned, I have added error log to the validation function in case user enters incorrect option. I see a bunch of other places in code, where string based flags have no enum counterpart and validation is done in default validator function. Please take a look at latest PS. If you still think enum would make sense and why, I don't mind add one. Also, flag and its validator is moved to net_util.cc now. It seems more appropriate to be placed under net util. -- To view, visit http://gerrit.cloudera.org:8080/23411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e Gerrit-Change-Number: 23411 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 26 Sep 2025 14:05:39 +0000 Gerrit-HasComments: Yes
