Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23451 )
Change subject: KUDU-3662 [6/n] Add createTable flag and table initialization logic ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23451/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationTableInitializer.java File java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationTableInitializer.java: http://gerrit.cloudera.org:8080/#/c/23451/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationTableInitializer.java@55 PS1, Line 55: sourceClient = new KuduClient.KuduClientBuilder( : String. join(",", config.getSourceMasterAddresses())).build(); : sinkClient = new KuduClient.KuduClientBuilder( : String.join(",", config.getSinkMasterAddresses())).build(); : sourceTableName = config.getTableName(); : sinkTableName = config.getSinkTableName(); : restoreOwner = config.getRestoreOwner(); > for the clients we need to have them instantiated in the initializer class. yeah, sorry, the clients are fine, the last three variables are what I wanted to select http://gerrit.cloudera.org:8080/#/c/23451/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationTableInitializer.java@78 PS1, Line 78: <p>This method is a Java port of the Scala method with the same name from : * the kudu-backup module in KuduRestore.createTableRangePartitionByRangePartition > Yes this was exactly my thought process. There is just one fundamental diff okay, makes sense, thanks! -- To view, visit http://gerrit.cloudera.org:8080/23451 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1002b4ba272c1acaab351e3ff3f341ca327070d2 Gerrit-Change-Number: 23451 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 24 Sep 2025 09:26:33 +0000 Gerrit-HasComments: Yes
