Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23407 )
Change subject: KUDU-3697: Bundle kudu-spark classes ...................................................................... Patch Set 1: Code-Review+1 I'm fine with this fix to go in to unblock 1.18.1. I guess this is again coming from the mismatch of how maven and gradle considers these dependency scopes. By maven's standards this is indeed a "compile" dependency as: "Compile dependencies are available in all classpaths of a project." I guess this includes the runtime classpath as well, hence the inclusion of the classes in the jar. According to gradle this is an "implementation" dependency: " Dependencies required for both compilation and runtime." However, implementation scoped dependencies will be generated with runtime scopes (by the maven-publish gradle plugin), even though the Maven runtime dependency explicitly states that "This scope indicates that the dependency is not required for compilation, but is for execution.". I don't think we have too many better options than manually tweaking these as there seems to be a fundamental difference of how dependency scopes are considered by the two build systems. https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html https://docs.gradle.org/current/userguide/dependency_configurations.html#sub:what-are-dependency-configurations -- To view, visit http://gerrit.cloudera.org:8080/23407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d3e3c95efe161adc916332477f8cd9f35c48e38 Gerrit-Change-Number: 23407 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 12 Sep 2025 08:47:23 +0000 Gerrit-HasComments: No
