Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23403 )
Change subject: KUDU-3696 Improve Python Client Makefile ...................................................................... Patch Set 1: (1 comment) just one more nit regarding the readme. tested the commands on ubuntu18 \w python2. everything seems to work nicely. Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/23403/1/python/README.md File python/README.md: http://gerrit.cloudera.org:8080/#/c/23403/1/python/README.md@90 PS1, Line 90: ## Using the Makefile : : A Makefile is provided to simplify common development tasks. It includes targets for building, installing dependencies, running tests, and cleaning the project. : : ```bash : # Install all dependencies : make requirements : : # Build the extension in-place : make build : : # Run all tests : make test : : # Run a specific test : make test TEST=kudu.tests.test_client.TestClient.test_list_tables : : # Clean build artifacts : make clean : ``` nit: i think its better if the makefile section is at the very end of the dev section. first describing all the python commands. and then displaying at the very end the convenience make commands. -- To view, visit http://gerrit.cloudera.org:8080/23403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb71816f754dc01b494727c04fcf00838e7d1f9f Gerrit-Change-Number: 23403 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 11 Sep 2025 08:02:31 +0000 Gerrit-HasComments: Yes
