Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/23145 )
Change subject: KUDU-1261 update CFile {en,de}coders for array data type
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23145/8/src/kudu/cfile/type_encodings.cc
File src/kudu/cfile/type_encodings.cc:
http://gerrit.cloudera.org:8080/#/c/23145/8/src/kudu/cfile/type_encodings.cc@268
PS8, Line 268: if (!typeinfo->is_array()) {
: return
Singleton<TypeEncodingResolver>::get()->GetDefaultEncoding(
: typeinfo->physical_type());
: }
:
: // For 1D arrays, the encoder is chosen based on the type of
the array's
: // elements.
: const auto* nested_type_desc = typeinfo->nested_type_info();
: DCHECK(nested_type_desc);
: DCHECK(nested_type_desc->is_array());
: const auto* elem_type_info =
nested_type_desc->array().elem_type_info();
: // Only 1D arrays of scalar types are supported yet.
: DCHECK(!elem_type_info->nested_type_info());
> Maybe avoid code duplication here?
Do you mean add a function to get the type of the array elements given the
TypeInfo for the array itself?
Thanks, it's a good idea.
--
To view, visit http://gerrit.cloudera.org:8080/23145
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie84debb6dd8f81ce013cb3330b07c6abe2534c0b
Gerrit-Change-Number: 23145
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Sep 2025 05:03:21 +0000
Gerrit-HasComments: Yes
