Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23246 )
Change subject: KUDU-3662 [5/n] Add metrics support to replication ...................................................................... Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/23246/4/java/kudu-replication/src/main/java/org/apache/kudu/replication/wrappedsource/MetricWrappedKuduEnumerator.java File java/kudu-replication/src/main/java/org/apache/kudu/replication/wrappedsource/MetricWrappedKuduEnumerator.java: http://gerrit.cloudera.org:8080/#/c/23246/4/java/kudu-replication/src/main/java/org/apache/kudu/replication/wrappedsource/MetricWrappedKuduEnumerator.java@127 PS4, Line 127: private long getLastEndTimestamp() { : long hybridTime = ReflectionSecurityUtils.getLongFieldValue(lastEndTimestampField, delegate); : long[] parsed = HybridTimeUtil.HTTimestampToPhysicalAndLogical(hybridTime); : long epochMicros = parsed[0]; : return epochMicros / 1_000; : } Thank you for adding these details -- it helps. > "this approach assumes it's not necessary to track changes that happened > withing the same physical timestamp": not sure if I understand, is the > question towards the general replication mechanism or just about what is > exposed as metrics? That was mostly a concern about whether this metric can provide enough information if something isn't yet replicated at the target side and whether it's possible to have a situation when something is stuck, but this metric doesn't allow to see the problem. But since you clarified about using the timestamps with 0 logical counter for the diff scan snapshots, I think exposing just the physical timestamp is enough, yep. This looks good to me then: I don't think exposing the logical part of the timestamp is needed in this context. http://gerrit.cloudera.org:8080/#/c/23246/4/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationMetrics.java File java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationMetrics.java: http://gerrit.cloudera.org:8080/#/c/23246/4/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationMetrics.java@129 PS4, Line 129: > Did run TSAN through dist-test a 1000 times all successful. [1] Thank you very much for checking this out! Indeed, 1000 passing out of 1000 should be good enough. -- To view, visit http://gerrit.cloudera.org:8080/23246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibfbd34c707e7539ee88863399ae3061683f8bb3b Gerrit-Change-Number: 23246 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 09 Sep 2025 03:16:25 +0000 Gerrit-HasComments: Yes
