Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23364 )
Change subject: KUDU-1261 add array.fbs into common/serdes ...................................................................... Patch Set 3: > > Will this need followup changes to support decimal type? > > I'm not planning to support DECIMAL128 in this iteration at all. > Same for INT128. > > As for DECIMAL32 and DECIMAL64, they are covered by UInt32 and > UInt64. If necessary, we can add corresponding shims on top of > existing union descriptors. For more context, Flatbuffers is rather a transport layer, so there isn't a direct correspondence between Kudu types and corresponding Flatbuffer types if looking at the representation of the data in memory and on the wire. As for INT128 and DECIMAL128 support, I think we can achieve it by either: * Patching Flatbuffers in Kudu's 3rd-party to natively support 16-byte integers, and adding corresponding shims in this .fbs file * Use the UInt64 to pass the data, interpreting 2 consecutive 64-bit numbers as parts of one 128 number. That's uglier, but it should work. -- To view, visit http://gerrit.cloudera.org:8080/23364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2c25aa32e3a72aada61e8980eb2613f8f649481 Gerrit-Change-Number: 23364 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 03 Sep 2025 23:40:02 +0000 Gerrit-HasComments: No
