Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23367 )
Change subject: [build] detect undefined but evaluated macros ...................................................................... Patch Set 1: > Looks like there are some more macros undefined being caught and > failing the build. For example: > > In file included from > /home/jenkins-slave/workspace/build_and_test/src/kudu/util/metrics.h:250: > /home/jenkins-slave/workspace/build_and_test/src/kudu/gutil/ref_counted.h:274:5: > error: 'SCOPED_REFPTR_ALLOW_IMPLICIT_CONVERSION_TO_PTR' is not > defined, evaluates to 0 [-Werror,-Wundef] > #if SCOPED_REFPTR_ALLOW_IMPLICIT_CONVERSION_TO_PTR > ^ > 1 error generated. Right -- that was because I removed one updated in gutil code which I still have in my workspace (so I didn't see any breakages). I assumed the flag in src/kudu/gutil/CMakeLists.txt would take care of that, but the issue is that the code in ref_counted.h is included in many other sub-projects. I returned it back, so now it should be OK. -- To view, visit http://gerrit.cloudera.org:8080/23367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f60f08b41c675a2a7307664a2ef0c7ecf8d682e Gerrit-Change-Number: 23367 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 02 Sep 2025 22:14:50 +0000 Gerrit-HasComments: No
