Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23045 )
Change subject: Add REST API integration tests ...................................................................... Patch Set 7: Code-Review+1 (3 comments) small nits, otherwise looks good to me http://gerrit.cloudera.org:8080/#/c/23045/7/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/23045/7/src/kudu/integration-tests/master_authz-itest.cc@1061 PS7, Line 1061: verify isolation: User A creates a new table How does User A creating a table verify isolation? Could you rephrase this a bit? http://gerrit.cloudera.org:8080/#/c/23045/7/src/kudu/integration-tests/master_authz-itest.cc@1063 PS7, Line 1063: NO_FATALS(this->GrantCreateTablePrivilege({kDatabaseName})); : NO_FATALS(this->GrantDropTablePrivilege({kDatabaseName, "test_table"})); : ASSERT_OK(CreateKuduTable(kDatabaseName, "test_table")); could you leave a note in the comments, that these methods default to using the kTestUser as the owner? http://gerrit.cloudera.org:8080/#/c/23045/7/src/kudu/integration-tests/master_authz-itest.cc@1113 PS7, Line 1113: AssertUnauthorizedResponse(s, buf.ToString()); maybe it would be best to call kdestroy at the end of this block to make sure the authentications are completely separated -- To view, visit http://gerrit.cloudera.org:8080/23045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd3ff0dfd67cbc2b5ed0454372dd2bcea71e2ba3 Gerrit-Change-Number: 23045 Gerrit-PatchSet: 7 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 18 Aug 2025 13:18:57 +0000 Gerrit-HasComments: Yes
