Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23056 )
Change subject: WIP [thirdparty] introduce Flatbuffers ...................................................................... Patch Set 4: (4 comments) I took a cursory look. Still wrapping my head around this. No major comments. Mostly, have some questions. http://gerrit.cloudera.org:8080/#/c/23056/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23056/4//COMMIT_MSG@15 PS4, Line 15: serializing and de-serializing : of array cells' data question - What was the motivation behind starting to think about an alternative tool (and not protobuf) for serdes-ing of array cells' data? What about data types other than 'array'? Do those also need to be serdes-ed using alternative tool? http://gerrit.cloudera.org:8080/#/c/23056/4//COMMIT_MSG@20 PS4, Line 20: Arrow IPC format for : serdes-ing data of nested type cells' question - Any gain in using Apache IPC for simple types? http://gerrit.cloudera.org:8080/#/c/23056/4//COMMIT_MSG@27 PS4, Line 27: Flatbuffers IIUC flatbuffers provide fast access to fields inside a buffer by maintaining extra metadata in the form of 'offsets'. I am not sure but do you think that can lead to a bigger binary size? Maybe the increase in size is not significant (if any)? http://gerrit.cloudera.org:8080/#/c/23056/4/src/kudu/benchmarks/serdes/serdes-test.cc File src/kudu/benchmarks/serdes/serdes-test.cc: http://gerrit.cloudera.org:8080/#/c/23056/4/src/kudu/benchmarks/serdes/serdes-test.cc@327 PS4, Line 327: Flatbuffers nit: Protobuf -- To view, visit http://gerrit.cloudera.org:8080/23056 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c697b8d80cbbd2af4233d16806a230cedaa81a Gerrit-Change-Number: 23056 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 14 Jul 2025 15:40:21 +0000 Gerrit-HasComments: Yes
