Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22819 )
Change subject: [util] introduce ChunkedBitmapIterator ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22819/4/src/kudu/util/bitmap.h File src/kudu/util/bitmap.h: http://gerrit.cloudera.org:8080/#/c/22819/4/src/kudu/util/bitmap.h@147 PS4, Line 147: virtual size_t Next(bool* value) = 0; > Are you sure changing this from an inline to a virtual function won't have That's a good question. Certainly, this have performance impact, but I don't think it's something huge in the big picture. I haven't looked at particular tests to assess the perf impact, though. I considered using templatized approach instead, but it wasn't good. Alternatively, I considered getting rid of the common base and using those two independent classes, but that adds extra limitations on use cases. However, it seems I can get away with using specific type of iterator at particular call sites, at least in my drafted changes which I'm working on. Do you have any particular idea for an alternative? I appreciate your inputs! -- To view, visit http://gerrit.cloudera.org:8080/22819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I143e3caa7cd8d48be8034c630f79562c2fc1282a Gerrit-Change-Number: 22819 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 08 Jul 2025 19:07:04 +0000 Gerrit-HasComments: Yes
