Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23063 )
Change subject: [thrift] Add support for extra Thrift options to THRIFT_GENERATE_CPP() ...................................................................... Patch Set 5: (1 comment) Overall LGTM, just one extra request for PS5. Thank you for working on this! http://gerrit.cloudera.org:8080/#/c/23063/5/cmake_modules/FindThrift.cmake File cmake_modules/FindThrift.cmake: http://gerrit.cloudera.org:8080/#/c/23063/5/cmake_modules/FindThrift.cmake@126 PS5, Line 126: ${ARG_EXTRA_OPTIONS} Usually, extra options come in the very tail of the rest of the standard list of options -- that way it's often possible to override the default/standard ones. That's true for many tools that apply such rules for their options/argument ordering, and I guess Thrift compiler is one of those tools. Please consider following that pattern here as well, moving ${ARG_EXTRA_OPTIONS} just before ${EXTRA_THRIFT_PATH_ARGS}. -- To view, visit http://gerrit.cloudera.org:8080/23063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdb8b650f9b8ed1cdea9dd0cf1a80ef264ccc7d7 Gerrit-Change-Number: 23063 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 27 Jun 2025 19:26:11 +0000 Gerrit-HasComments: Yes
