KeDeng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23049 )

Change subject: [arm64] Fix TestLeafNode unit test by ensuring proper node 
alignment
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23049/1/src/kudu/tablet/cbtree-test.cc
File src/kudu/tablet/cbtree-test.cc:

http://gerrit.cloudera.org:8080/#/c/23049/1/src/kudu/tablet/cbtree-test.cc@72
PS1, Line 72: // In unit tests, we explicitly enforce 8-byte alignment for 
LeafNode/InternalNode
> Please add a small doc blurb for the TestCBTree class to explain the alignm
Done


http://gerrit.cloudera.org:8080/#/c/23049/1/src/kudu/tablet/cbtree-test.cc@100
PS1, Line 100:
> nit for here and elsewhere: what is the alignment requirement here?  Must t
Done



--
To view, visit http://gerrit.cloudera.org:8080/23049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib838699ce3f966b2e7c371d5c74701f2f8d21a55
Gerrit-Change-Number: 23049
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Jun 2025 06:50:33 +0000
Gerrit-HasComments: Yes

Reply via email to