Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22867 )
Change subject: KUDU-3665 Send Send no-op heartbeat operations batched PART1 ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/22867/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22867/7//COMMIT_MSG@15 PS7, Line 15: fewer RPC calls Do we want to capture the number of rpc calls between the servers as a part of benchmarking? http://gerrit.cloudera.org:8080/#/c/22867/7//COMMIT_MSG@29 PS7, Line 29: If nit: if http://gerrit.cloudera.org:8080/#/c/22867/7/src/kudu/consensus/multi_raft_batcher.cc File src/kudu/consensus/multi_raft_batcher.cc: http://gerrit.cloudera.org:8080/#/c/22867/7/src/kudu/consensus/multi_raft_batcher.cc@154 PS7, Line 154: locking nit: to lock http://gerrit.cloudera.org:8080/#/c/22867/7/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/22867/7/src/kudu/tserver/tablet_service.cc@1846 PS7, Line 1846: mzzzzzzz nit: typo? -- To view, visit http://gerrit.cloudera.org:8080/22867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie92ba4de5eae00d56cd513cb644dce8fb6e14538 Gerrit-Change-Number: 22867 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 10 Jun 2025 05:30:55 +0000 Gerrit-HasComments: Yes
