Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22822 )
Change subject: WIP KUDU-1457: IPv6 support for Kudu ...................................................................... Patch Set 1: >For impala, is "no port" specified a valid use case? This only came up in impala-shell, which can take both host and host:port as commandline argument, so handled both cases. https://gerrit.cloudera.org/#/c/22527/24/shell/impala_shell/impala_shell.py In other places I checked we pass the port and host separately, so bracketing is not relevant in this case. The only case where bracketing is really standard is when using an ipv6 address in an url. -- To view, visit http://gerrit.cloudera.org:8080/22822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab9225f7465a647876670562e4dee3911e3208a9 Gerrit-Change-Number: 22822 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 29 May 2025 17:21:40 +0000 Gerrit-HasComments: No
