Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing ...................................................................... Patch Set 19: (3 comments) Looks better compared with PS18, just a few nits and questions left. http://gerrit.cloudera.org:8080/#/c/22768/18/java/gradle/shadow.gradle File java/gradle/shadow.gradle: http://gerrit.cloudera.org:8080/#/c/22768/18/java/gradle/shadow.gradle@65 PS18, Line 65: > nit: remove the stray space? Did you miss addressing this strayed space in PS19? http://gerrit.cloudera.org:8080/#/c/22768/19/java/kudu-backup-tools/build.gradle File java/kudu-backup-tools/build.gradle: http://gerrit.cloudera.org:8080/#/c/22768/19/java/kudu-backup-tools/build.gradle@49 PS19, Line 49: testCompileOnly project(path: ":kudu-backup-common") Is this a duplicate for the directive at line 38 above? http://gerrit.cloudera.org:8080/#/c/22768/19/java/kudu-backup/build.gradle File java/kudu-backup/build.gradle: http://gerrit.cloudera.org:8080/#/c/22768/19/java/kudu-backup/build.gradle@48 PS19, Line 48: testCompileOnly Wouldn't it be enough to have testImplementation dependency from 'kudu-spark' for 'shadow' configuration, instead of this testCompileOnly for 'shadow' configuration and testImplementation below at line 52 for 'test' configuration as well? -- To view, visit http://gerrit.cloudera.org:8080/22768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0 Gerrit-Change-Number: 22768 Gerrit-PatchSet: 19 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 27 May 2025 18:58:26 +0000 Gerrit-HasComments: Yes
