Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22013 )
Change subject: [docs] Update Kudu 1.18.0 release notes ...................................................................... Patch Set 7: (24 comments) http://gerrit.cloudera.org:8080/#/c/22013/6/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/22013/6/docs/release_notes.adoc@202 PS6, Line 202: (see https://issues.apache.org/jira/browse/KUDU-3549[KUDU-3549]). : * Fixed integer overflow in avail > nit: I am curious. Can you point me to the commit id for this one. KUDU-3516 http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@73 PS7, Line 73: * Widened the list of HTTP methods in detecting an HTTP client connecting to Kudu server’s : RPC port. > I'd think we might omit details like this since this doesn't have a lot of Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@75 PS7, Line 75: Added a new metric to track per-RPC timeouts. This helps in identifying if requests to a : particular RPC method timed out while being processed. > Does it make sense to add a link to KUDU-3514 here? Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@89 PS7, Line 89: commit > changelist 35716499d Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@92 PS7, Line 92: commit > changelist 3bdaf50b5 Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@104 PS7, Line 104: * Previously absent min/max keys in rowset metadata are now populated during tablet server bootstrap : after switching --rowset_metadata_store_keys to 'true'. > Consider removing this since it doesn't have a lot of user-related exposure Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@133 PS7, Line 133: * Kudu C++ client now allows setting rpc_max_message_size : (see https://issues.apache.org/jira/browse/KUDU-3595[KUDU-3595]). > Is this a duplicate of the item above? Yes, forgot to delete it. Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@135 PS7, Line 135: Prometheus metrics are now available at tablet level. Previously they were only available at : server level > Tablet-level metrics are now available in Prometheus format as well. Previo Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@137 PS7, Line 137: KUDU-3633[KUDU-3563]) > typo: the link and the tag don't match. Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@138 PS7, Line 138: for multiple tables > ... for multiple tables and against the whole Kudu cluster. Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@139 PS7, Line 139: Upgraded several C++ and Java 3rd-party dependencies: > As for the list of 3rd-party components in the updated list marked as "C++ I think these upgrades were done primarily due to report of KUDU-3626. So putting a note about it here instead of listing all the upgrades done. http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@191 PS7, Line 191: The example Kudu C++ client application now works with HMS-enabled Kudu clusters. > Move this into the 'Optimizations and improvements' section. Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@222 PS7, Line 222: huge response payloads > response payloads up to 2GByte in size Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@240 PS7, Line 240: * Fixed the Ranger client log count limit not working. > Remove this since this is a test-only fix. Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@261 PS7, Line 261: * Fixed the issue where trailing null/zero bytes were truncated : (see https://issues.apache.org/jira/browse/KUDU-3646[KUDU-3646]). > Instead, remove this and add an entry on KUDU-3648: Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@263 PS7, Line 263: Fixed the issue where retrying close() syscall on EINTR is addressed > close() isn't retried on EINTR anymore Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@270 PS7, Line 270: * Fixed unnecessary dependencies introduced in KUDU-3551 : (see https://issues.apache.org/jira/browse/KUDU-3610[KUDU-3610]). > Remove this since KUDU-3551 functionality isn't present in any of the previ Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@272 PS7, Line 272: * Fixed heap-use-after-free issue in Op-driver : (see https://issues.apache.org/jira/browse/KUDU-3620[KUDU-3620]). > This seems to be a duplicate of the entry at line 256 Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@274 PS7, Line 274: > Add a note about KUDU-3661 once it cherry-picked into the 1.18.x branch. Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@302 PS7, Line 302: Applications : written against Kudu 1.17 will compile and run against the Kudu 1.18 client library and : vice-versa. > Just to double-check: is this still so after upgrading Gradle to 7.6.4 vers Yes, tested this against kudu java example from the repo and noticed no issues. Will add a note here accordingly. http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@312 PS7, Line 312: Applications : written against Kudu 1.17 will continue to run against the Kudu 1.18 client : and vice-versa. > I guess the main thing to mention here is that we did not introduce breakin Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@318 PS7, Line 318: > It's a good point, indeed. As discussed let's add this to Known issues and limitations of the documentation (Kudu 1.10 and above). http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@321 PS7, Line 321: > I think it makes sense to add a note on know issues described by KUDU-3635. Done http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@325 PS7, Line 325: Kudu 1.18.0 includes contributions from 26 people, including 3 first-time contributors: > It seems there is at least one more contributor to add into the list: Done -- To view, visit http://gerrit.cloudera.org:8080/22013 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.18.x Gerrit-MessageType: comment Gerrit-Change-Id: I57642af58d86de0d8f8bc26d06c4607fac6ea321 Gerrit-Change-Number: 22013 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Fri, 25 Apr 2025 01:00:46 +0000 Gerrit-HasComments: Yes
