Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/22797


Change subject: [rpc-test] fix flakiness in TimedOutOnResponseMetricServiceQueue
......................................................................

[rpc-test] fix flakiness in TimedOutOnResponseMetricServiceQueue

Before this patch, the TestRpc.TimedOutOnResponseMetricServiceQueue
scenario would fail from time to time (about once in every 100 runs)
when running on a VM in AWS cloud with error message like below:

  src/kudu/rpc/rpc-test.cc:1499: Failure
  Value of: s.IsTimedOut()
    Actual: false
  Expected: true
  Remote error: Got some error

I haven't seen it if running on nodes backed by a dedicated hardware,
and I guess that's due to scheduler anomalies induced by shared virtual
environment.  However, I didn't look deeper and just increased the sleep
time 10x and added 2x margin for RPC timeout.  With this patch, there
hasn't been a single failure in more than 10K runs of the test scenario.
The scenario still runs quite fast on modern hardware: less than 500ms.

Change-Id: I70008836a38def70e097bc4547ac2a66e7203e35
Reviewed-on: http://gerrit.cloudera.org:8080/22747
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
(cherry picked from commit e65914e386339a11e61d5a8cb24d66bf606fd41a)
---
M src/kudu/rpc/rpc-test.cc
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/22797/1
--
To view, visit http://gerrit.cloudera.org:8080/22797
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70008836a38def70e097bc4547ac2a66e7203e35
Gerrit-Change-Number: 22797
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>

Reply via email to