Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 )
Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test File testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test: http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test@334 PS3, Line 334: row_regex: 47:AGGREGATE * 2 * 2 > This was added in the parent patch, why's it changed in this one? These lines are part of the explain plan. The explain plan changed due to one of the recent commits http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test File testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test: http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test@94 PS3, Line 94: ---- RESULTS: VERIFY_IS_SUBSET > Why change this when there's also a CALCITE_PLANNER_RESULTS section? Prolly changed this while testing and realized I needed a different subsection after. Reverted it. -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 15 Apr 2026 13:09:48 +0000 Gerrit-HasComments: Yes
