Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24129 )
Change subject: IMPALA-14840: Enforce pool Max Memory when query limits are unset ...................................................................... IMPALA-14840: Enforce pool Max Memory when query limits are unset Impala should use memory-based query admission when Max Memory is set for the given pool. However, if Min Query Memory Limit, Max Query Memory Limit are missing, and query option MEM_LIMIT is not set, then currently queries can run with unlimited resources. This can cause a situation when Max Memory is specified, but the pool can consume basically unlimited memory. This patch fixes ScheduleState::UpdateMemoryRequirements() to not turn off memory-based query admission when Max Memory is set. The patch also removes the unused 'root_cfg' parameter of AdmissionController::CanAdmitRequest(). Testing * new admission controller backend tests added * updated pool 'poolNoMemLimits' in mem-limit-test-fair-scheduler.xml to not specify Max Memory Change-Id: I4834964e4361895e10627a661831253ce676c129 Reviewed-on: http://gerrit.cloudera.org:8080/24129 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/scheduling/admission-controller-test.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/scheduling/schedule-state.cc M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/test/resources/mem-limit-test-fair-scheduler.xml M tests/custom_cluster/test_admission_controller.py 7 files changed, 144 insertions(+), 37 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4834964e4361895e10627a661831253ce676c129 Gerrit-Change-Number: 24129 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
