Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24017 )
Change subject: IMPALA-14484: Calcite planner: Add column stats to union slot descriptors ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/24017/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24017/1//COMMIT_MSG@9 PS1, Line 9: Some tests were failing in the following e2e file: > Please explain why the tests were failing. I got rid of this comment. I haven't seen any tests failing recently, so perhaps it was some other issue. But the estimates are still accurate, so I still think this should be committed. http://gerrit.cloudera.org:8080/#/c/24017/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java: http://gerrit.cloudera.org:8080/#/c/24017/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java@87 PS1, Line 87: new TupleDescriptorFactory("union", rowType, columnStats); > Nit: unnecessary object construction. Done -- To view, visit http://gerrit.cloudera.org:8080/24017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0585fafa45658dffffdbf6410b028f03304b6e9 Gerrit-Change-Number: 24017 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sat, 11 Apr 2026 01:35:23 +0000 Gerrit-HasComments: Yes
