Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24174 )
Change subject: IMPALA-14881: Fix instance id in scanner threads ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24174/2/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/24174/2/be/src/exec/hdfs-scan-node.cc@342 PS2, Line 342: GetThreadDebugInfo()->SetInstanceId(state->fragment_instance_id()); > Now that it just merged, I wonder if we should have used a ScopedThreadCont Maybe not important; query ID should already be correct, and scanner thread will be updated the next time it's used. -- To view, visit http://gerrit.cloudera.org:8080/24174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ccfb94353843eaa83cf7371788d0fc151fd3e50 Gerrit-Change-Number: 24174 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 09 Apr 2026 00:15:22 +0000 Gerrit-HasComments: Yes
