Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24171 )
Change subject: IMPALA-14876: Use char* for thread name in impala::Thread::SuperviseThread ...................................................................... Patch Set 3: (1 comment) > Patch Set 2: > > I was able to grab /stacks and see fragment IDs > > 3 threads with same stack: > TID 98683 (exec-finstance (finst:b249fe358cfba516:9f1b07a100000005)): > TID 98689 (exec-finstance (finst:b249fe358cfba516:9f1b07a100000002)): > TID 98692 (exec-finstance (finst:b249fe358cfba516:9f1b07a10000000b)): > @ 0x7ee6b5642520 (unknown) > @ 0x3e08ffa base::internal::SpinLockDelay() > @ 0x3e64c4d SpinLock::SlowLock() > @ 0x44b06c8 tcmalloc::CentralFreeList::Populate() > @ 0x44b07c8 tcmalloc::CentralFreeList::FetchFromOneSpansSafe() > @ 0x44b0864 tcmalloc::CentralFreeList::RemoveRange() > @ 0x44c0be8 tcmalloc::ThreadCache::FetchFromCentralCache() > @ 0x3c376a7 llvm::SmallDenseMap<>::grow() > @ 0x3c38402 llvm::ReplaceableMetadataImpl::addRef() > @ 0x3c384c1 llvm::MetadataTracking::track() > @ 0x3c38745 llvm::MDNode::MDNode() > @ 0x3c3bf89 llvm::MDTuple::getImpl() > @ 0x3acc7f7 > llvm::MetadataLoader::MetadataLoaderImpl::parseOneMetadata() > @ 0x3ad1dbb > llvm::MetadataLoader::MetadataLoaderImpl::parseMetadata() > @ 0x3ad2480 llvm::MetadataLoader::parseMetadata() > @ 0x3ab0fab (anonymous namespace)::BitcodeReader::parseModule() Thanks for merging this! Note that /stacks page and /thread-group pages get the thread names directly from impala (i.e. ThreadMgr) so they are already fine. This patch is mostly a hack for external debuggers (gdb/pstack) to print the thread name while printing method parameters. http://gerrit.cloudera.org:8080/#/c/24171/1/be/src/util/thread.cc File be/src/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/24171/1/be/src/util/thread.cc@353 PS1, Line 353: // Disable optimization for this function so the compiler won't elide uses of parameters, https://jenkins.impala.io/job/clang-tidy-ub2004/12398/ failure on this: /home/ubuntu/Impala/be/src/util/thread.cc:353:16: warning: unknown attribute 'optimize' ignored [clang-diagnostic-unknown-attributes] -- To view, visit http://gerrit.cloudera.org:8080/24171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fa831d4efd7d8665f9c69fcea960e8e1c47aa2b Gerrit-Change-Number: 24171 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 08 Apr 2026 08:30:26 +0000 Gerrit-HasComments: Yes
