Yida Wu has uploaded a new patch set (#6). ( 
http://gerrit.cloudera.org:8080/21309 )

Change subject: IMPALA-12046: Add profile counter for scan range queueing time 
on disk queues
......................................................................

IMPALA-12046: Add profile counter for scan range queueing time on disk queues

This patch introduces a new counter TotalDiskIoQueueTime in the query
profile to track the total wall-clock time spent waiting in disk
queues for the specific hdfs scan node.

Instead of using per-range timers and aggregating queueing time
across request ranges, this change uses a shared ConcurrentStopWatch
to measure concurrent wall-clock time while ranges are queued.
Each range starts the timer when it is enqueued and stops it when
dequeued, contributing to the overall wall-clock time, so the metric
reflects the true wall-clock time for the ranges waiting in the disk
queue for this specific hdfs scan node.

Tests:
Added new testcase custom_cluster/test_disk_io_queue.py.

Change-Id: Ia0cb24db36cd89933c150b88e166e68a3abc7a60
---
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/runtime/io/disk-io-mgr.cc
M be/src/runtime/io/request-context.cc
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
A tests/custom_cluster/test_disk_io_queue.py
7 files changed, 111 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/21309/6
--
To view, visit http://gerrit.cloudera.org:8080/21309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia0cb24db36cd89933c150b88e166e68a3abc7a60
Gerrit-Change-Number: 21309
Gerrit-PatchSet: 6
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>

Reply via email to