Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24059 )
Change subject: IMPALA-14700: Add support for Parquet LZ4_RAW compression ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Thanks for working on this, the code looks good. I just want to change a bit of the commit message to specify that this is the read support. http://gerrit.cloudera.org:8080/#/c/24059/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24059/5//COMMIT_MSG@7 PS5, Line 7: Add support for Parquet LZ4_RAW compression Can we change this to "Add read support for Parquet LZ4_RAW compression"? http://gerrit.cloudera.org:8080/#/c/24059/5//COMMIT_MSG@16 PS5, Line 16: This patch adds support for LZ4_RAW. It uses Lz4Compressor : (Corresponding to THdfsCompression::LZ4). Let's specify that this is read support and add a sentence saying that the write path hasn't changed and continues to use LZ4_BLOCKED. -- To view, visit http://gerrit.cloudera.org:8080/24059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22ee4e5bf9abec37be941c1dca8019a563343d34 Gerrit-Change-Number: 24059 Gerrit-PatchSet: 5 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 24 Mar 2026 05:03:52 +0000 Gerrit-HasComments: Yes
