Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24063 )
Change subject: IMPALA-14794: Implement small string optimization in Parquet scanner ...................................................................... Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/24063/15/be/src/exec/parquet/parquet-column-chunk-reader.cc File be/src/exec/parquet/parquet-column-chunk-reader.cc: http://gerrit.cloudera.org:8080/#/c/24063/15/be/src/exec/parquet/parquet-column-chunk-reader.cc@84 PS15, Line 84: if (mem_pool != nullptr) { > If mem_pool is not nullptr, it's probably safer to pass ownership to it via Done http://gerrit.cloudera.org:8080/#/c/24063/15/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/24063/15/be/src/exec/parquet/parquet-column-readers.cc@848 PS15, Line 848: > nit: requires +4 indent Done http://gerrit.cloudera.org:8080/#/c/24063/15/be/src/runtime/smallable-string.h File be/src/runtime/smallable-string.h: http://gerrit.cloudera.org:8080/#/c/24063/15/be/src/runtime/smallable-string.h@125 PS15, Line 125: r > nit: parenthesis are redundant Done -- To view, visit http://gerrit.cloudera.org:8080/24063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16c550d35cd6d3ec259b899b325611294137ccef Gerrit-Change-Number: 24063 Gerrit-PatchSet: 16 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2026 11:11:12 +0000 Gerrit-HasComments: Yes
