Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24008 )
Change subject: IMPALA-14332: Add X-Request-Id as HttpRequestId attribute on root OTel span ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/24008/6/tests/custom_cluster/test_otel_trace.py File tests/custom_cluster/test_otel_trace.py: http://gerrit.cloudera.org:8080/#/c/24008/6/tests/custom_cluster/test_otel_trace.py@532 PS6, Line 532: # Python implementation of process_request_id_for_attribute : def process_request_id_py(request_id): : if not request_id: : return "" : last_hyphen = request_id.rfind('-') : if last_hyphen == -1: : return request_id : return request_id[:last_hyphen] : : # Create hs2-http client with http_tracing enabled to send X-Request-Id headers : impalad_service = self.cluster.impalads[0].service : client = ImpalaHS2 > I like the thoroughness of this function, but it seems like more than is ne Done http://gerrit.cloudera.org:8080/#/c/24008/6/tests/util/otel_trace.py File tests/util/otel_trace.py: http://gerrit.cloudera.org:8080/#/c/24008/6/tests/util/otel_trace.py@675 PS6, Line 675: __assert_attr(span.name, span.attributes, "UserName", user_name) > This if statement needs an else assert "HttpRequestId" not in init_span.att Done http://gerrit.cloudera.org:8080/#/c/24008/6/tests/util/otel_trace.py@680 PS6, Line 680: assert_attr(span.name, span.attributes, "Coordinator", coordinator) : : # If http_request_id is expected, validate it exists and matches the expected value : if http_request_id is not None: : assert "HttpRequestId" in span.attrib > Please move this validation up into the assert_trace function so that inval Done http://gerrit.cloudera.org:8080/#/c/24008/6/tests/util/otel_trace.py@721 PS6, Line 721: original_query_id) > This if statement needs an else assert "HttpRequestId" not in init_span.att Done -- To view, visit http://gerrit.cloudera.org:8080/24008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e14f5b503ff7379463332bae34c266afc395524 Gerrit-Change-Number: 24008 Gerrit-PatchSet: 7 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Fri, 13 Mar 2026 04:56:29 +0000 Gerrit-HasComments: Yes
