Hello Jason Fehr, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24008
to look at the new patch set (#4).
Change subject: IMPALA-14332: Add X-Request-Id as HttpRequestId attribute on
root OTel span
......................................................................
IMPALA-14332: Add X-Request-Id as HttpRequestId attribute on root OTel span
When using the hs2-http protocol, the X-Request-Id HTTP header value
is now captured and added as an attribute named "HttpRequestId" on the
root OpenTelemetry span. The iteration count suffix (e.g., "-8" in
"uuid-8") that the Impala shell appends is automatically removed to
provide a clean UUID for tracing.
Implementation details:
- Capture X-Request-Id header in THttpServer and store in ConnectionContext
- Propagate value to SessionState during session creation
- Add HttpRequestId attribute to root span in SpanManager constructor
Testing:
- Added C++ unit tests (otel-test.cc) for request ID processing
- Added Python integration test using ImpalaHS2Client over hs2-http
- Test verifies HttpRequestId attribute format and cross-checks with logs
Change-Id: I9e14f5b503ff7379463332bae34c266afc395524
---
M be/src/observe/otel-trace-manager-test.cc
M be/src/observe/otel-trace-manager.cc
M be/src/rpc/authentication.cc
M be/src/rpc/thrift-server.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.h
M be/src/transport/THttpServer.cpp
M be/src/transport/THttpServer.h
M tests/custom_cluster/test_otel_trace.py
M tests/util/otel_trace.py
10 files changed, 238 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/24008/4
--
To view, visit http://gerrit.cloudera.org:8080/24008
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e14f5b503ff7379463332bae34c266afc395524
Gerrit-Change-Number: 24008
Gerrit-PatchSet: 4
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
