Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23204 )
Change subject: IMPALA-14234: Fix a version mismatch DCHECK hit when admissiond cluster membership recovering ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23204/2/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/23204/2/be/src/scheduling/cluster-membership-mgr.cc@297 PS2, Line 297: // The recovering membership is not exposed to clients unless the post-recovery : // grace pe > The recovering snapshot could be used to update current snapshot and as a r Can we say that, "The recovering membership is not exposed to clients unless the post-recovery grace period has passed. Before that, no copying is needed. After the grace period, it will be set to the current membership and cleared". I added this comment. http://gerrit.cloudera.org:8080/#/c/23204/2/be/src/scheduling/cluster-membership-mgr.cc@300 PS2, Line 300: // to current membership and cleared. : new_state = recovering_membership_; : if (current_membership_ != nullptr : > It looks like the issue is that we're maintaining separate snapshots in rec Yeah, one way could be removing the DCHECK in https://github.com/apache/impala/blob/branch-4.5.1/be/src/scheduling/admission-controller.cc#L2224, since the version in the queued node could be higher. However, it seems no harm to bump the version here to match the current one, and doing so may be more consistent -- To view, visit http://gerrit.cloudera.org:8080/23204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea77347bd4775abd7866817146e326c7c5042f5e Gerrit-Change-Number: 23204 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 30 Jul 2025 17:53:49 +0000 Gerrit-HasComments: Yes
