Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23185 )
Change subject: IMPALA-14094: Prepend to commit, refactor estimated table stats ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/23185/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23185/3//COMMIT_MSG@10 PS3, Line 10: statistics for the original planner are estimated within HdfsScanNode > nit: to be clear, the estimation here is done when there's missing stats (s Done http://gerrit.cloudera.org:8080/#/c/23185/3/fe/src/main/java/org/apache/impala/planner/HdfsEstimatedTableStats.java File fe/src/main/java/org/apache/impala/planner/HdfsEstimatedTableStats.java: http://gerrit.cloudera.org:8080/#/c/23185/3/fe/src/main/java/org/apache/impala/planner/HdfsEstimatedTableStats.java@75 PS3, Line 75: > Since all statistics are 'estimated' (well, row counts are more accurate th Done http://gerrit.cloudera.org:8080/#/c/23185/3/fe/src/main/java/org/apache/impala/planner/HdfsEstimatedTableStats.java@75 PS3, Line 75: > Correction : I meant HdfsEstimatedMissingTableStats (added the 'd'in the es Done http://gerrit.cloudera.org:8080/#/c/23185/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/23185/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@341 PS3, Line 341: eStats estima > Similar to the class naming, this could be changed to estimatedMissingStats Done -- To view, visit http://gerrit.cloudera.org:8080/23185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I522e5105867fa1c85df5c04a4bc6cdd5d63443f0 Gerrit-Change-Number: 23185 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 21 Jul 2025 22:09:22 +0000 Gerrit-HasComments: Yes
